[WIP] fs2 explore #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-rd
reviewed
Jun 29, 2025
| arr | ||
|
|
||
| extension (buf: ByteBuffer) | ||
| def put[C <: Value: FromExpr: Tag, S: ClassTag](chunk: Chunk[S])(using bridge: Bridge[C, S]): ByteBuffer = |
Member
There was a problem hiding this comment.
I'd recommend we just use fromByteBuffer, toByteBuffer directly from Bridge. Those extension methods can be slightly misleading, as they appear to come from the original java API and add an extra step to follow when reading the code.
|
|
||
| def fromByteBuffer(outBuf: ByteBuffer, arr: Array[fRGBA]): Array[fRGBA] = | ||
| val res = outBuf.asFloatBuffer() | ||
| for i <- 0 until arr.size do arr(i) = (res.get(), res.get(), res.get(), res.get()) |
Member
There was a problem hiding this comment.
That will definitely be the slowest part of the program, we have to think about a way to speed up those memory transfers - So in the essence do that somehow without the iteration. Maybe we should treat RGBA as Array[Float] not a tuple.
The same goes for the toByteBuffer.
Collaborator
Author
|
I think there is a bug in LayoutStruct, where izumi tags are summoned, probably for GBuffers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.