Mzlakowski/layout type #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarconZet
force-pushed
the
mzlakowski/layout-type
branch
from
f1c65e6 to
03bcba8
Compare
szymon-rd
approved these changes
Jan 6, 2026
MarconZet
commented
Jan 6, 2026
Collaborator
Author
MarconZet
left a comment
MarconZet
left a comment
There was a problem hiding this comment.
Can't approve my own PR
| else | ||
| Apply(readyConstructor, args).asExprOf[T] | ||
|
|
||
| // val s = layoutSymbol.primaryConstructor.paramSymss |
Collaborator
Author
There was a problem hiding this comment.
remove comments from files
| def reqAllocBinding: LayoutBinding[ReqAlloc] = summon[LayoutBinding[ReqAlloc]] | ||
| def resAllocBinding: LayoutBinding[ResAlloc] = summon[LayoutBinding[ResAlloc]] | ||
| sealed trait GBufferRegion[ReqAlloc: Layout, ResAlloc: Layout]: | ||
| def reqAllocLayout: Layout[ReqAlloc] = summon[Layout[ReqAlloc]] |
Collaborator
Author
There was a problem hiding this comment.
I would rewrite summon[Layout[ReqAlloc]] to Layout[ReqAlloc] and create Layout.apply method (similar to Tag.apply)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.