Skip to content

initial attempt for deploy module account transaction handler #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 5, 2025
Merged

initial attempt for deploy module account transaction handler #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f3421cf
initial attempt for deploy module account transaction handler
Nov 4, 2025
4167a19
added a null check for module length
Nov 4, 2025
69c6c5a
amended changelog
Nov 4, 2025
fad08c6
added an initial attempt of test
Nov 4, 2025
632c2af
double checking the test for deploy module
Nov 4, 2025
ef4c3c3
Merge branch 'main' into SPO-34/account-transaction-handler
rbaconcordium Nov 4, 2025
738c1a5
some fixes due to deprecation warnings as per Soren's suggestion
Nov 4, 2025
7e47776
Merge branch 'SPO-34/account-transaction-handler' of https://github.c…
Nov 4, 2025
9fe68fe
ran prettier
Nov 4, 2025
917ff9e
trying to see if this is the build error problem
Nov 4, 2025
23ba5ff
tidy up typo and blank space
Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Added

- deserialize function for DeployModulePayload implemented instead of throwing an exception of not supporting deserialize

## 11.0.0

### Fixed
Expand Down
17 changes: 15 additions & 2 deletions packages/sdk/src/accountTransactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,21 @@ export class DeployModuleHandler implements AccountTransactionHandler<DeployModu
}
}

deserialize(): DeployModulePayload {
throw new Error('deserialize not supported');
deserialize(serializePayload: Cursor): DeployModulePayload {
const moduleVersion = serializePayload.read(4); // version
const moduleLength = serializePayload.read(4)?.readUInt32BE(0); // length
const moduleSource = serializePayload.read(moduleLength); // wasm module

if (moduleVersion) {
return {
source: new Uint8Array(moduleSource),
version: moduleVersion.readUInt32BE(0),
};
} else {
return {
source: new Uint8Array(moduleSource),
};
}
}

toJSON(payload: DeployModulePayload): DeployModulePayloadJSON {
Expand Down
9 changes: 9 additions & 0 deletions packages/sdk/test/ci/deserialization.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
CcdAmount,
ContractAddress,
DataBlob,
DeployModulePayload,
RegisterDataPayload,
SequenceNumber,
SimpleTransferPayload,
Expand Down Expand Up @@ -80,6 +81,14 @@ test('test deserialize registerData ', () => {
deserializeAccountTransactionBase(AccountTransactionType.RegisterData, payload);
});

test('test deserialize DeployModule ', () => {
const payload: DeployModulePayload = {
version: 1,
source: new Uint8Array([0x00, 0xab, 0x53, 0x03, 0x92, 0x68, 0x10, 0xee]),
};
deserializeAccountTransactionBase(AccountTransactionType.DeployModule, payload);
});

test('Expired transactions can be deserialized', () => {
const payload: SimpleTransferPayload = {
amount: CcdAmount.fromMicroCcd(5100000),
Expand Down