RUN-41 Serde deprecated #318

AHaliq · 2025-08-28T11:11:37Z

Purpose

Guard serde relevant constructs behind a feature flag eventually to be turned off by default

Changes

created a tool to parse and transform rust AST to add the guards idempotently
run cd serde-refactor && cargo run -- ../concordium-rust-sdk/src --dry-run to see candidates in src
apply transformation to src/** and examples/**

Checklist

My code follows the style of this project.
The code compiles without warnings.
I have performed a self-review of the changes.
I have documented my code, in particular the intent of the
hard-to-understand areas.
(If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.

serde-refactor/src/main.rs

Cargo.toml

README.md

src/internal.rs

src/contract_client.rs

Cargo.toml

src/types/network.rs

README.md

src/types/summary_helper.rs

CHANGELOG.md

allanbrondum

Just have a few comments for making changelog more precise

AHaliq requested a review from allanbrondum August 28, 2025 11:11

AHaliq self-assigned this Aug 28, 2025

AHaliq added [Size] Large [Type] Maintenance Cleanup or handling of technical debt. question Further information is requested Breaking change labels Aug 28, 2025

AHaliq marked this pull request as draft August 28, 2025 11:11

allanbrondum reviewed Aug 28, 2025

View reviewed changes

serde-refactor/src/main.rs Outdated Show resolved Hide resolved

AHaliq force-pushed the serde_deprecated branch 7 times, most recently from e8c4d78 to 323233a Compare September 1, 2025 10:20

AHaliq force-pushed the serde_deprecated branch from 323233a to 490efba Compare September 29, 2025 08:37

AHaliq marked this pull request as ready for review October 6, 2025 08:59

AHaliq changed the title ~~[DRAFT] COR-1759 Serde deprecated~~ COR-1759 Serde deprecated Oct 6, 2025

allanbrondum reviewed Oct 6, 2025

View reviewed changes

Cargo.toml Show resolved Hide resolved

allanbrondum reviewed Oct 6, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

allanbrondum reviewed Oct 6, 2025

View reviewed changes

src/internal.rs Show resolved Hide resolved

allanbrondum reviewed Oct 6, 2025

View reviewed changes

src/contract_client.rs Show resolved Hide resolved

AHaliq force-pushed the serde_deprecated branch 3 times, most recently from c8544c7 to 69e9ac5 Compare November 5, 2025 08:43

AHaliq marked this pull request as draft November 5, 2025 08:44

AHaliq changed the title ~~COR-1759 Serde deprecated~~ RUN-41 Serde deprecated Nov 5, 2025

AHaliq marked this pull request as ready for review November 10, 2025 13:09