-
Notifications
You must be signed in to change notification settings - Fork 493
chore: regenerate tinyfield #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
was the bitReverse refactor needed because a linter complained the old one is marked Deprecated ? |
Exactly! https://github.com/Consensys/gnark/actions/runs/17613708150/job/50041471329#step:7:29 I can also nolint tag it. |
|
And there is no big rush from my side. I wanted to merge Consensys/gnark-crypto#725, but then need #1601 on gnark side to fix some existing tests which assume gnark-crypto current behaviour. And that lead to linter errors which I wanted to fix in this PR. But the initial issue is still imo great to merge - it allows for compatibility with other ecdsa libs. |
0e6e75c to
d0b8fd0
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@gbotrel - reverted using utils.BitReverse and added nolint instead. |
|
why? dependency issue ? |
gbotrel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, don't get why we can't use the non-deprecated method in gnark-crypto but it's a quick refactor anyway once we sort all the branches out
|
The BitReverse in fft packages is denoted deprecated and recommended using BitReverse in utils package. It made linter complain and I changed to the utils package version. But you noted above that you'll probably refactor the utils package. So I reverted and added nolint instead. And I need gnark-crypto update to fix ECDSA. But it introduces the changes to code generation which makes tests here (checking code generation) fail. |
Description
Update gnark-crypto dependency and regenerate tinyfield implementation to avoid CI failures due to dirty tree after generation.
Type of change
Checklist:
golangci-lintdoes not output errors locallyNote
Updates gnark-crypto and testify, regenerates tinyfield with new exponent APIs (scalar and vector) and minor ops tweaks, adds empty-slice tests, and annotates BitReverse uses with nolint across backends/templates/tests.
github.com/consensys/gnark-cryptotov0.19.3-0.20251114....github.com/stretchr/testifytov1.11.1.Element.ExpInt64and routeElement.Expto it forint64exponents (supports negatives).Vector.Exp(a, k int64)for batch exponentiation with negative-exponent handling.MulBy3viaDouble+Add.TestVectorEmptyOpsensuring zero-length vector ops don’t panic and return zero.fft.BitReverse(...)calls with//nolint:staticcheckinbackend/plonk/*/prove.go, GKR gate testing, templates, andtest/unsafekzg/kzgsrs.go(backward-compatible API usage).Written by Cursor Bugbot for commit 4de3fa7. This will update automatically on new commits. Configure here.