-
Notifications
You must be signed in to change notification settings - Fork 21
TXN_DATA
redesign
#173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TXN_DATA
redesign
#173
Conversation
|
rlp_txn_v2/columns/transaction.tex
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there modif here ? Some of them are shared columns already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there modif here ? Some of them are shared columns already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What's the purpose of the changes in BLK ? To expose some values for the lookup TXN_DATA -> BLK ?
- we could update the TXN_DATA -> RLP_RCPT ugly lookup in this PR as well
- I guess you plan to update the system transaction in the HUB in a further PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has to be deleted
txn_data_user/_all_txn_data_user.tex
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has to be renaled txn_data
txn_data_user/_inputs.tex
Outdated
\subsection{Introduction} \label{user txn data: generalities: intro} \input{intro} | ||
\subsection{Columns} \label{user txn data: generalities: columns} \input{columns} | ||
\section{Transaction data module} \label{user txn data: generalities} | ||
\subsection{Introduction} \label{user txn data: intro} \input{intro} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The picture doesn't load for me
% $\txnDataRlpNumAccountDelegations$: | ||
% number of account delegations | ||
% for \cite{EIP-7702} transactions; | ||
\item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need it in txn_data, the lookup is rlp_txn into blk
rlp_txn_v2/columns/transaction.tex
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is there modif here ? Some of them are shared columns already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only reordering right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, finishing the lookup which was incomplete.
The first one is already done here IIRC. I would rather do the other ones in separate PR's. |
* feat: adding WCP and EUC specific result columns * feat: update "RES" logging in shorthands * ras
No description provided.