Skip to content

Conversation

OlivierBBB
Copy link
Collaborator

No description provided.

Copy link

cla-assistant bot commented May 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented May 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlivierBBB OlivierBBB enabled auto-merge (squash) August 26, 2025 09:47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there modif here ? Some of them are shared columns already

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there modif here ? Some of them are shared columns already

Copy link
Contributor

@letypequividelespoubelles letypequividelespoubelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • What's the purpose of the changes in BLK ? To expose some values for the lookup TXN_DATA -> BLK ?
  • we could update the TXN_DATA -> RLP_RCPT ugly lookup in this PR as well
  • I guess you plan to update the system transaction in the HUB in a further PR ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has to be deleted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has to be renaled txn_data

\subsection{Introduction} \label{user txn data: generalities: intro} \input{intro}
\subsection{Columns} \label{user txn data: generalities: columns} \input{columns}
\section{Transaction data module} \label{user txn data: generalities}
\subsection{Introduction} \label{user txn data: intro} \input{intro}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the intro,
Uploading image.png…
has to be updated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The picture doesn't load for me

% $\txnDataRlpNumAccountDelegations$:
% number of account delegations
% for \cite{EIP-7702} transactions;
\item
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need it in txn_data, the lookup is rlp_txn into blk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there modif here ? Some of them are shared columns already

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reordering right ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, finishing the lookup which was incomplete.

@OlivierBBB
Copy link
Collaborator Author

LGTM

  • What's the purpose of the changes in BLK ? To expose some values for the lookup TXN_DATA -> BLK ?
  • we could update the TXN_DATA -> RLP_RCPT ugly lookup in this PR as well
  • I guess you plan to update the system transaction in the HUB in a further PR ?

The first one is already done here IIRC. I would rather do the other ones in separate PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arithmetization hardfork cancun EIP's for the Cancun hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants