Skip to content

[CDX-386] Add seed item ids to rex events - #266

Merged
HHHindawy merged 6 commits into
masterfrom
cdx-386-swift-sdk-add-support-to-pass-seed-item-ids-to-rex-events
Apr 28, 2026
Merged

HHHindawy merged 6 commits into
masterfrom
cdx-386-swift-sdk-add-support-to-pass-seed-item-ids-to-rex-events

Conversation

@Mudaafi

@Mudaafi Mudaafi commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Adds support for seedItemIds for recommendation events:

  • trackRecommendationResultClick
  • trackRecommendationResultsView

@Mudaafi
Mudaafi requested a review from a team March 19, 2026 22:31
Copilot AI review requested due to automatic review settings March 19, 2026 22:31
constructor-claude-bedrock[bot]

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for passing seedItemIds through the SDK’s recommendation tracking APIs so recommendation view/click events can include seed item identifiers in their request payloads.

Changes:

  • Extend trackRecommendationResultsView and trackRecommendationResultClick public APIs to accept optional seedItemIds.
  • Include seed_item_ids in the HTTP body for recommendation view/click tracking request data when provided and non-empty.
  • Add/extend XCTest coverage for request payload building and tracking calls (plus an unrelated quiz integration test constant update).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
AutocompleteClient/FW/Logic/Worker/ConstructorIO.swift Adds seedItemIds parameter + forwards into request data; updates doc examples.
AutocompleteClient/FW/Logic/Request/CIOTrackRecommendationResultsViewData.swift Adds seedItemIds to request data and conditionally serializes seed_item_ids into payload.
AutocompleteClient/FW/Logic/Request/CIOTrackRecommendationResultClickData.swift Adds seedItemIds to request data and conditionally serializes seed_item_ids into payload.
AutocompleteClientTests/FW/Logic/Worker/ConstructorIOTrackRecommendationResultsViewTests.swift Adds worker-level test calling trackRecommendationResultsView(..., seedItemIds:).
AutocompleteClientTests/FW/Logic/Worker/ConstructorIOTrackRecommendationResultClickTests.swift Adds worker-level test calling trackRecommendationResultClick(..., seedItemIds:).
AutocompleteClientTests/FW/Logic/Request/TrackRecommendationViewRequestBuilder.swift Adds request-builder payload tests for seed_item_ids (single/multiple/empty).
AutocompleteClientTests/FW/Logic/Request/TrackRecommendationResultClickRequestBuilder.swift Adds request-builder payload tests for seed_item_ids (single/multiple/empty).
AutocompleteClientTests/FW/Logic/Worker/ConstructorIOQuizIntegrationTests.swift Updates quizVersionID constant used in quiz integration tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AutocompleteClient/FW/Logic/Worker/ConstructorIO.swift Outdated
Comment thread AutocompleteClient/FW/Logic/Worker/ConstructorIO.swift Outdated
constructor-claude-bedrock[bot]

This comment was marked as outdated.

esezen
esezen previously approved these changes Mar 27, 2026
@evanyan13
evanyan13 requested a review from a team as a code owner April 10, 2026 15:39
constructor-claude-bedrock[bot]

This comment was marked as outdated.

constructor-claude-bedrock[bot]

This comment was marked as outdated.

@constructor-claude-bedrock constructor-claude-bedrock Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds seedItemIDs support to trackRecommendationResultClick and trackRecommendationResultsView events. The implementation is clean, consistent with existing patterns, and well-tested — overall a solid addition.

Inline comments: 5 discussions added

Overall Assessment: ⚠️ Needs Work

@HHHindawy
HHHindawy merged commit 14aa6b1 into master Apr 28, 2026
3 checks passed
@HHHindawy
HHHindawy deleted the cdx-386-swift-sdk-add-support-to-pass-seed-item-ids-to-rex-events branch April 28, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants