Macos compatibility fix #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace hardcoded Linux paths with cross-platform detection - Add support for macOS (/Users/) and Windows (C:\Users\) paths - Maintain backward compatibility with existing Linux installations - Fixes issue where SkeletonKey fails to run on macOS systems This resolves path errors when running SkeletonKey on macOS where the user directory structure differs from Linux systems.
- Add key.sh wrapper script for virtual environment support - Automatically activates Python virtual environment before running SkeletonKey - Provides error checking for missing directories and virtual environments - Useful for systems with externally managed Python environments (modern macOS/Linux) This wrapper ensures SkeletonKey dependencies are properly isolated and loaded.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
markdown## Problem
SkeletonKey currently only works on Linux systems due to hardcoded
/home/paths inmods/bits.py. macOS users encounterFileNotFoundErrorwhen trying to run the tool.Solution
This PR adds cross-platform path detection that supports:
/Users/{username}/.SkeletonKey/home/{username}/.SkeletonKey(existing behavior)C:\Users\{username}\.SkeletonKeyChanges Made
mods/bits.pykey.sh) for modern Python environmentsTesting
Impact
This fix enables SkeletonKey to work on macOS and Windows systems, significantly expanding the tool's compatibility and user base.
Fixes the path detection issue that prevents macOS users from running SkeletonKey.