Skip to content

Fix ibc-go ISA-2025-001#1141

Merged
dimiandre merged 4 commits intomainfrom
vexxvakan/hotfix-1
Mar 24, 2025
Merged

Fix ibc-go ISA-2025-001#1141
dimiandre merged 4 commits intomainfrom
vexxvakan/hotfix-1

Conversation

@vexxvakan
Copy link
Member

@vexxvakan vexxvakan commented Mar 14, 2025

This PR fixes ibc-go ISA-2025-001

  • Bumped packet-forward-middleware to 8.2.0
  • Bumped ibc-hooks to 8.0.0 (full release)
  • Bumped ibc-go to 8.7.0
  • Fix incorrect wasm storage dir (released as v28.0.1)

This PR is not state-breaking so if it gets accepted we can release it as v28.0.2

@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2025

Walkthrough

The pull request updates the application by replacing the use of the wasmDir variable with the dataDir variable when initializing the WASM keeper in the NewAppKeepers function. Additionally, it updates several dependency versions in the go.mod and interchaintest/go.mod files to newer releases.

Changes

File(s) Change Summary
app/keepers/keepers.go Updated the NewAppKeepers function to use path.Join instead of filepath.Join for dataDir and wasmDir. Introduced wasmvm.NewVM for new WASM virtual machine instance creation.
go.mod Updated dependency versions: upgraded github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v8 to v8.2.0, set a fixed version for github.com/cosmos/ibc-apps/modules/ibc-hooks/v8, and updated github.com/cosmos/ibc-go/v8 to v8.7.0.
interchaintest/go.mod Updated dependency versions: changed github.com/CosmosContracts/juno/v28 from v28.0.0 to v28.0.1 and updated github.com/cosmos/ibc-go/v8 from v8.5.3 to v8.7.0.

Poem

I’m a rabbit on a coding spree,
Hopping through changes merrily.
Data paths now lead the way,
Keeping WASM’s code at play.
Dependencies updated with delight,
I celebrate this change under the moonlight.
🐇🌕 Happy hops and code so bright!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d92ceea and b2d4f98.

📒 Files selected for processing (1)
  • app/keepers/keepers.go (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (16)
  • GitHub Check: e2e-tests (ictest-clock)
  • GitHub Check: e2e-tests (ictest-cwhooks)
  • GitHub Check: e2e-tests (ictest-burn)
  • GitHub Check: e2e-tests (ictest-feepay)
  • GitHub Check: e2e-tests (ictest-drip)
  • GitHub Check: e2e-tests (ictest-unity-deploy)
  • GitHub Check: e2e-tests (ictest-ibc)
  • GitHub Check: e2e-tests (ictest-upgrade)
  • GitHub Check: e2e-tests (ictest-globalfee)
  • GitHub Check: e2e-tests (ictest-pfm)
  • GitHub Check: e2e-tests (ictest-feeshare)
  • GitHub Check: e2e-tests (ictest-tokenfactory)
  • GitHub Check: e2e-tests (ictest-ibchooks)
  • GitHub Check: e2e-tests (ictest-statesync)
  • GitHub Check: e2e-tests (ictest-basic)
  • GitHub Check: Analyze
🔇 Additional comments (4)
app/keepers/keepers.go (4)

4-11: Import changes reflect updated dependency requirements

The import changes align with the PR objective to fix ISA-2025-001 vulnerability. Replacing filepath with path and adding wasmvm import supports the changes needed to properly handle WASM storage paths and integrate the updated WASM VM capabilities.


223-224: Path handling is standardized with path.Join

The change from filepath.Join to path.Join for directory path construction ensures consistent forward-slash path separators. This is appropriate for the application since Cosmos chains typically run on Linux environments where forward slashes are standard.


540-544: Explicit WASM VM initialization adds security and control

The introduction of explicit WASM VM initialization with wasmvm.NewVM() is a critical addition that aligns with the security fix mentioned in ISA-2025-001. This provides better control over the WASM environment configuration and capabilities.


560-560: Fixed incorrect WASM storage directory

This change directly addresses the PR objective of fixing an incorrect WASM storage directory. Using dataDir instead of wasmDir ensures that WASM data is stored in the proper location, resolving the issue mentioned in the PR as version 28.0.1.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Mar 14, 2025
@dimiandre dimiandre enabled auto-merge (rebase) March 24, 2025 06:55
@dimiandre dimiandre merged commit 92542a0 into main Mar 24, 2025
24 checks passed
@vexxvakan vexxvakan deleted the vexxvakan/hotfix-1 branch March 25, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants