-
Notifications
You must be signed in to change notification settings - Fork 30
fix: scope JWT cookies by project ID to prevent audience mismatch warnings #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alfonso-paella
wants to merge
11
commits into
main
Choose a base branch
from
devin/1767991178-fix-jwt-cookie-scoping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c2ece74
fix: scope JWT cookies by API key prefix to prevent audience mismatch…
devin-ai-integration[bot] 7e23a93
fix: use project ID from API key instead of prefix for cookie scoping
devin-ai-integration[bot] 34c3f9f
fix: remove backward compatibility fallback to prevent cross-project …
devin-ai-integration[bot] 9d490a8
fix: smart legacy cookie handling - only fallback for refresh tokens
devin-ai-integration[bot] 2e99be0
chore: add changeset for JWT cookie scoping fix
devin-ai-integration[bot] 95ab1ac
fix: verify JWT audience matches current project after refresh
devin-ai-integration[bot] b571bab
chore: remove duplicate changeset
devin-ai-integration[bot] df93db6
chore: update changeset description
devin-ai-integration[bot] 9a99a57
refactor: remove JWT audience check - let warnings resolve naturally
devin-ai-integration[bot] 59ad41d
chore: add debug log for SSR case in ScopedCookieStorage
devin-ai-integration[bot] d220cf1
chore: remove unused getJWTAudience function
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@crossmint/client-sdk-auth": patch | ||
| --- | ||
|
|
||
| Moved JWT cookie scoping to allow for multiple project cookies in the same domain, and prevent issues of cookie mismatch during development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would change cookiestorage to use this implementation instead of having 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion! I kept both implementations for now to minimize the scope of this change, but consolidating them would be a good follow-up. The main difference is that
ScopedCookieStorageadds project ID scoping and legacy cookie fallback for refresh tokens. Would you like me to consolidate them in this PR or as a separate follow-up?