Modify deploy function tests to use proper role-based auth and expand smart-account tests

[alberto-crossmint]

Modify deploy function tests to use proper role-based auth and expand smart-account tests

Summary

This PR modifies the deploy function tests in the crossmint-contract-factory to use proper role-based authentication instead of mocking all auths, and expands the minimal smart-account test to include comprehensive functionality testing.

Key Changes:

• Removed e.mock_all_auths() from deploy function tests and replaced with proper authentication patterns
• Added negative test cases (test_non_deployer_cannot_deploy and test_non_deployer_cannot_upload_and_deploy) to verify role-based access control
• Expanded smart-account tests from a single empty test to comprehensive testing of __check_auth function and contract registration
• All tests now use actual WASM values for deployment testing

Current Status: ⚠️ 3 deploy function tests are currently failing due to authentication issues with the deployed CustomAccountInterface contract's constructor. The role-based access control for deploy operations is working correctly (negative tests pass), but the actual deployment tests fail when the smart-account contract's constructor is called.

Review & Testing Checklist for Human

• Critical: Investigate failing deploy tests - Understand why the CustomAccountInterface contract's constructor fails authentication even with e.mock_all_auths() and determine the correct approach for testing CustomAccountInterface deployment
• Verify negative test cases work correctly - Confirm that test_non_deployer_cannot_deploy and test_non_deployer_cannot_upload_and_deploy properly test role-based access control
• Review expanded smart-account tests - Ensure the new comprehensive tests in smart-account/src/test.rs are meaningful and properly test the contract's functionality
• Test end-to-end deployment - Run cargo test --workspace and verify the expected behavior for both positive and negative test cases

---

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    CF["contracts/crossmint-contract-factory/src/test.rs"]:::major-edit
    SA["contracts/smart-account/src/test.rs"]:::major-edit
    LIB["contracts/crossmint-contract-factory/src/lib.rs"]:::context
    WASM["contracts/crossmint-contract-factory/src/test_constants.rs"]:::context
    SLIB["contracts/smart-account/src/lib.rs"]:::context
    
    CF -->|"Uses WASM from"| WASM
    CF -->|"Tests deploy functions in"| LIB
    CF -->|"Deploys contracts from"| SLIB
    SA -->|"Tests functions in"| SLIB
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF

Loading

Notes

• Session Info: Requested by Alberto García (@alberto-crossmint) - Devin Session
• Authentication Issue: The failing tests suggest that CustomAccountInterface contracts have special deployment requirements that aren't satisfied by standard authentication mocking patterns
• Partial Success: While the main goal of using actual WASM and proper auth patterns was implemented, the tests don't pass due to the CustomAccountInterface deployment constraints
• Role-based Access Control: The negative test cases successfully demonstrate that non-deployers cannot call deploy functions, confirming that critical auth functionality is properly tested

[devin-ai-integration]

Original prompt from Alberto:

Modify all deploy function tests so they actually use the WASM value and they don't fail because of wasm not being available! If there's critical auth functionality that is mocked, unmock it


You only need to look in the following repo: Crossmint/stellar-smart-account

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

⚙️ Control Options:

• Disable automatic comment and CI monitoring