feat: support kubernetes tolerations for FalconAdmission and FalconImageAnalyzer#709
Open
ivanaguilario wants to merge 8 commits intoCrowdStrike:mainfrom
Open
feat: support kubernetes tolerations for FalconAdmission and FalconImageAnalyzer#709ivanaguilario wants to merge 8 commits intoCrowdStrike:mainfrom
ivanaguilario wants to merge 8 commits intoCrowdStrike:mainfrom
Conversation
Contributor
|
@ivanaguilario Thanks for creating this. Can you please add the following:
The above can also be achieved by updating watches with predicates. |
Author
|
Hi there @gpontejos! Thanks for taking a look. Sorry for the late reply, got a bit busy the past few weeks. I added the reconciler checks as requested. I saw there was already some similar work done so for consistency I took the same approach. Let me know if anything else is needed. Thanks! |
|
Any reason why this is not going forward? I cannot deploy KAC and IAR without that.. |
Author
|
Hi @gpontejos I went ahead and updated my branch with main and resolved the merge conflicts. Let me know if there's anything we can do to get this merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for kubernetes tolerations in the
FalconAdmissionandFalconImageAnalyzerCRDs.Closes #654
This is blocking us from deploying Crowdstrike Falcon across all our Kubernetes clusters as we use tolerations in order to gate workloads to specific node groups.
Added e2e tests for deploying
FalconAdmission,FalconImageAnalyzerandFalconNodeSensorwith tolerations set.