storage: add RuntimeError::ResizedByAnotherProcess
#499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinto-janai
added
C-fix
Boog900
reviewed
Jun 28, 2025
Comment on lines
138
to
143
| if ConcreteEnv::MANUAL_RESIZE | ||
| && matches!( | ||
| response, | ||
| Err(RuntimeError::ResizeNeeded | RuntimeError::ResizedByAnotherProcess) | ||
| ) | ||
| { |
Member
There was a problem hiding this comment.
IMO this should still be a panic for the write interface - no other process should write to cuprated's database.
The read tower interface should handle this though IMO, currently it just returns an error.
Boog900
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
RuntimeError::ResizedByAnotherProcessand related handling code tostorage/crates.Why
If another process resizes the database file, the storage code will currently panic.
Discussed here: monero-project/meta#1212.