Deprecate using Tanjun contexts as DI contexts take 2 #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FasterSpeeding
commented
Nov 29, 2024
FasterSpeeding
commented
Nov 29, 2024
| This includes deprecating the relevant methods inherited from | ||
| [alluka.abc.Context][] and [alluka.BasicContext][]. | ||
| - Providing the following classes as global type-dependencies: | ||
| * [hikari.impl.RESTClientImpl][] |
There was a problem hiding this comment.
reformat these
FasterSpeeding
force-pushed
the
task/contexts-2
branch
from
6e6f967 to
d072230
Compare
FasterSpeeding
force-pushed
the
task/contexts-2
branch
from
e40b5e3 to
e8211a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues