Skip to content

Fix MRCPSynth arguments #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix MRCPSynth arguments #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba694d1
Fix MRCPSynth arguments
jeffdoubleyou Sep 30, 2021
d3c1db6
module import change
jeffdoubleyou Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/CyCoreSystems/agi
module github.com/jeffdoubleyou/agi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude this change


require github.com/pkg/errors v0.8.1

Expand Down
7 changes: 5 additions & 2 deletions mrcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,11 @@ type SynthResult struct {
func (a *AGI) MRCPSynth(prompt string, opts string) (res *SynthResult, err error) {
var cause string
res = new(SynthResult)

ret, err := a.Exec([]string{"MRCPSynth", prompt, opts}...)
execOpts := []string{
fmt.Sprintf(`"%s"`, prompt),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit heavy to use fmt.Sprintf() just to wrap a string in double-quotes; maybe just

 `"` + prompt + `"`

?

opts,
}
ret, err := a.Exec([]string{"MRCPSynth", strings.Join(execOpts, ",")}...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to declare a []string{} and then expand it (...), should we?
Maybe just

ret, err := a.Exec("MRCPSynth", strings.Join(execOpts, ","))

?

if err != nil {
return
}
Expand Down