Add self restarts for workstations#646
Merged
RayofLightz merged 3 commits intodevelopmentfrom Jan 15, 2026
Merged
Conversation
Contributor
Author
|
I will say I am thinking about moving the lock acquisition from the db object creator into the actual run_container function. Just because that is more true to where the lock is actually needed and will reduce the need for constantly calling to redis for a lock. As create_indvidual_container gets called each time the vnc forwarder is hit. |
zoecough
approved these changes
Jan 15, 2026
| ctr.stop(timeout=5) | ||
| except docker.errors.NotFound: | ||
| pass | ||
| redis_client = get_redis_client(3) |
Contributor
Author
There was a problem hiding this comment.
The idea is it should be connecting to its own redis "table"
Contributor
Author
There was a problem hiding this comment.
Idk if its actually doing in practice though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does two main things of importance