Skip to content

Robustify search and delete on qdrant_db#115

Open
lisa-lthorrold wants to merge 1 commit into
D-Star-AI:mainfrom
lisa-lt:bugfix/robust_search_delete_vector_db
Open

Robustify search and delete on qdrant_db#115
lisa-lthorrold wants to merge 1 commit into
D-Star-AI:mainfrom
lisa-lt:bugfix/robust_search_delete_vector_db

Conversation

@lisa-lthorrold

Copy link
Copy Markdown
Contributor

Unlike other vector db implementations where the client creates the collection in the constructor, this one creates it on first add (it checks to see if the collection/kb exists first). This means that calling delete or search will throw an exception if the knowledge base doesn't exist.

I do feel a graceful failure is better from a user experience but it could mask bugs, depending on how the library is integrated with other systems. Other option is to make it consistent with our other vector db implementations deal with this issue, and initialise the kb if it doesn't exist in the constructor - but there is further complications there. In the local .db version, you can only have 1 client per process (which covers all knowledge bases), so if you tie the first (and only instantiation) of the client - then multiple knowledge bases cannot be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants