VLM ABC refactor#128
Merged
Merged
Conversation
…th backward-compatible wrappers Create a reusable VLM client abstraction and concrete implementations (Gemini, Vertex) while keeping current free functions working. No wiring changes yet.
…atible) Integrate the new VLM clients into dsparse parsing and KnowledgeBase while preserving legacy dict-based configs and behavior.
Finalize VLM ABC integration by aligning types, improving error messages, adding missing tests, and documenting usage.
… parsing Add a real-API, env-gated test to validate the new VLM client (serialized) path in parse_and_chunk.
Add a real-API, env-gated test in the top-level integration suite to validate the serialized VLM client path.
…, and back-compat) Revise top-level README.md and dsrag/dsparse/README.md to document the new VLM ABC usage, fallback configuration, and backward compatibility with legacy dict configs.
AndreaBellomia
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies VLM file parsing to use the same abstract base class (ABC) architecture that all the other components use, while maintaining full backwards compatibility with the existing dictionary-based model config method.