feat: update index language buttons with Google Translate selection#467
Open
PouyaMohseni wants to merge 3 commits intodevelopfrom
Open
feat: update index language buttons with Google Translate selection#467PouyaMohseni wants to merge 3 commits intodevelopfrom
PouyaMohseni wants to merge 3 commits intodevelopfrom
Conversation
- Change the link and text of `Visit English Site` btn when a language is set by Google translate - Ensure it reflects Google Translate selection if chosen in another tab - Prevent old event listeners from firing ref: #434
Member
|
The linked issue doesn't really explain this PR. Can you explain why this is necessary? The changes can confuse the user, as google translate may not support all the languages in wikidata. The simplest change would be making the button non-translatable, and always direct to the english site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #434
BEFORE:
