Replace google drive with microsoft defender for vacancy and job application malware scanning#8643
Open
KyleMacPherson wants to merge 52 commits intomainfrom
Open
Replace google drive with microsoft defender for vacancy and job application malware scanning#8643KyleMacPherson wants to merge 52 commits intomainfrom
KyleMacPherson wants to merge 52 commits intomainfrom
Conversation
|
Review app deployed to https://teaching-vacancies-review-pr-8643.test.teacherservices.cloud on AKS |
92b5601 to
7caf553
Compare
451c1eb to
26c11f7
Compare
KyleMacPherson
commented
Apr 15, 2026
| label: { text: "Upload application form", tag: "h1", size: "l" }, | ||
| hint: { text: t("helpers.hint.publishers_job_listing_application_form_form.application_form") }, | ||
| accept: ".doc, .docx, .pdf", | ||
| accept: ".doc, .docx, .pdf, .txt", |
Collaborator
Author
There was a problem hiding this comment.
This is just to allow us to test with eicar.txt to simulate a malicious file and will be removed before deploying.
KyleMacPherson
commented
Apr 15, 2026
| javascript: true, | ||
| label: { size: "m" }, | ||
| accept: ".doc, .docx, .pdf", | ||
| accept: ".doc, .docx, .pdf, .txt", |
Collaborator
Author
There was a problem hiding this comment.
This is just to allow us to test with eicar.txt to simulate a malicious file and will be removed before deploying.
KyleMacPherson
commented
Apr 15, 2026
| label: { text: vacancy_form_page_heading(vacancy, step_process, back_path: back_path), tag: "h1", size: "l" }, | ||
| hint: { text: t("helpers.hint.publishers_job_listing_documents_form.documents") }, | ||
| accept: ".doc, .docx, .pdf", | ||
| accept: ".doc, .docx, .pdf, .txt", |
Collaborator
Author
There was a problem hiding this comment.
This is just to allow us to test with eicar.txt to simulate a malicious file and will be removed before deploying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
Changes in this PR:
This PR removes the google drive antivirus flow for the hiring staff job publishing flow and the jobseeker job application flow. Instead we switch over to using microsoft defender for storage. The key difference is that the antivirus scanning is done async on azure. To account for this change, in the flows mentioned above we will allow users to continue through the wizard steps if the file has not been scanned and only block them from progressing if the file is flagged as malicious or the azure scan has errored. We will however stop them from actually publishing the job or submitting the application until the file has been scanned and tagged as safe. See below for more detailed information on each flow with screenshots.
Hiring staff uploaded application form
Hiring staff additional documents
jobseeker uploaded job application
jobseeker catholic application form
Screenshots of UI changes:
Before
After
Checklists:
Data & Schema Changes
If this PR modifies data structures or validations, check the following:
If any of the above options has changed then the author must check/resolve all of the following...
Integration Impact
Does this change affect any of these integrations?
User Experience & Data Integrity
Could this change impact: