Add view and delete uploaded reference functionality#8705
Open
KyleMacPherson wants to merge 3 commits intomainfrom
Open
Add view and delete uploaded reference functionality#8705KyleMacPherson wants to merge 3 commits intomainfrom
KyleMacPherson wants to merge 3 commits intomainfrom
Conversation
|
Review app deployed to https://teaching-vacancies-review-pr-8705.test.teacherservices.cloud on AKS |
KyleMacPherson
force-pushed
the
reference-request-file
branch
from
ef89d2a to
c16d0a3
Compare
scruti
reviewed
Apr 17, 2026
| @@ -50,6 +50,14 @@ | |||
| = summary_list.with_row do |row| | |||
Collaborator
There was a problem hiding this comment.
Being a little bit nitpicky here, if the attached/uploaded references have no values for the fields we may want to just not show the empty fields?
So we may always show the name and condition the rest of "when no reference doc is attached"?
Regarding this
scruti
approved these changes
Apr 17, 2026
Collaborator
scruti
left a comment
scruti
left a comment
There was a problem hiding this comment.
LGTM! Left a non blocking suggestion on hiding some fields from the view when not applicable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
Changes in this PR:
In a previous PR i was adding functionality to view and delete previously uploaded files in preparation for the new anti-virus flow as we move from google drive to defender. I missed the uploaded reference in that PR.
I have had to slightly change the UI for this to allow deletion, so we no longer just show the file name on the pre-interview checks page for uploaded references but instead follow the same flow as other references where we click the referee name which links us to a page which shows the details and, in the case of uploaded references, allows us to delete the reference. Please see screenshots.
Screenshots of UI changes:
Before
After
Checklists:
Data & Schema Changes
If this PR modifies data structures or validations, check the following:
If any of the above options has changed then the author must check/resolve all of the following...
Integration Impact
Does this change affect any of these integrations?
User Experience & Data Integrity
Could this change impact: