[0.12] Refactor Attribute Lists#591
[0.12] Refactor Attribute Lists#591Severino wants to merge 5 commits into0.12-feat-required-attributesfrom
Conversation
| certainty, | ||
| handleSelectionUpdate, | ||
| additionalRowClasses, | ||
| addModerationStateClasses, |
There was a problem hiding this comment.
I sorted the return alphabetically.
| /> | ||
| </button> | ||
| </div> | ||
| <FabButtonList |
There was a problem hiding this comment.
I replaced this directly with the fabbuttonlist component. (As it also served as template for that component)
| item-key="id" | ||
| class="attribute-list-container align-content-start" | ||
| :class="classes" | ||
| ghost-class="vue-draggable-ghost" |
There was a problem hiding this comment.
I wanted to use multiple bootstrap classes, but it's not possible. See in _style.scss
which then uses bootstrap variables.
I get the idea, but I didn't really touch that much of the code and it was working fine. With this it makes no sense to me to implement any feature/logic, because it takes weeks or even months for another PR to get reviewed and merged. Then I have to fiddle around to merge my code into a completely new logic... |
Severino
changed the title
2 participants
A big priority of mine is to make things more manageable when we touch them:
Smaller, reusable components and externalizing business logic.
Therefore, I'm currently refactoring the AttributeControls and move them out of the AttributeList (which very bloated, as it supports functionality of every place it is implemented in).