chore: rm seg classes - #287
Conversation
remove the potential breaking seg classes.
There was a problem hiding this comment.
Pull request overview
This PR removes tei-seg* CSS classes from “Erläuterungen” example markup to avoid potentially breaking segment-based styling and to rely on the project’s simpler, named classes.
Changes:
- Removed
tei-seg*classes from several example<span>elements in transcription explanations. - Updated example class usage to use existing semantic classes like
initial,glory-initial, andnot-executed. - Minor markup reformatting for readability in the “Überschriften” example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/components/erlaeuterungen-components/ErlaeuterungenTranskriptionen.svelte | Drops tei-seg* classes in examples; switches to simpler semantic classes and adjusts markup formatting. |
| src/lib/components/erlaeuterungen-components/ErlaeuterungenFassungsedition.svelte | Drops tei-seg9 from the “Initialen” example to align with the new class scheme. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Versalien und Majuskeln werden in Fettdruck wiedergegeben (z. B.: <span class="majuscule" | ||
| >D</span | ||
| >iz). |
flicksolutions
left a comment
flicksolutions
left a comment
There was a problem hiding this comment.
Farbe: rot is definetly not a css class. a space and a colon?
See this thread for css-class naming rules: https://stackoverflow.com/questions/448981/which-characters-are-valid-in-css-class-names-selectors
This has nothing to do with this PR. In this PR we simply remove "seg". This is a preexisting issue which needs to be tackled. The template/html parts of the examples were not my idea. They simply were 1:1 copies from the rendered html of the fassungen and the transkriptionen at the time of introducing them. Instead of questioning the exmples here we should question the generated html. Worthwile to check that in a separate issue. Maybe the html is rendered disregarding any |
You are right... Sorry. I must have just snapped at the sight of these Classnames. I opened a new issue and approve this PR. |
flicksolutions
left a comment
flicksolutions
left a comment
There was a problem hiding this comment.
the requested changes were not concerning this PR. Opened a new Issue to adress this.
remove the potential breaking seg classes.