[9.0] Drop the direct use of the JobStateUpdateClient from servers#8121
Merged
chrisburr merged 1 commit intoDIRACGrid:integrationfrom Apr 7, 2025
Merged
Conversation
chrisburr
force-pushed
the
drop-JobStateUpdateClient-server
branch
from
9672a68 to
d86b689
Compare
chaen
reviewed
Apr 7, 2025
| """ | ||
|
|
||
| stateServer = JobStateUpdateClient(useCertificates=useCertificates) | ||
| stateServer = _JobDBInteraction(useCertificates) |
Contributor
There was a problem hiding this comment.
you're going to run into the same issue with the JobMonitoringClient below.
Member
Author
There was a problem hiding this comment.
I know but that is used in multiple places so I thought it was better to focus on one client at a time.
chrisburr
commented
Apr 7, 2025
| vo = returnValueOrRaise(self._jobStatusUtility.jobDB.getJobAttribute(jobID, "VO")) | ||
| return self._elasticJobParametersDB.setJobParameter(int(jobID), key, value, vo=vo) | ||
| else: | ||
| return self._client.setJobParameter(jobID, key, value) |
Member
Author
There was a problem hiding this comment.
To draw attention to this, I think JobStateUpdateClient().setJobParameter no longer works with a host certificate as the VO isn't knonw.
cc @fstagni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*RequestManagement
CHANGE: No longer directly use of the JobStateUpdateClient when processing requests
FIX: Calling setJobParameter when processing requests
*Transformation
CHANGE: No longer directly use of the JobStateUpdateClient from the DataRecoveryAgent
ENDRELEASENOTES