fix (WMS): do not import DB in utilities #8283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we move these functions to |
chaen
force-pushed
the
v9.0_fix_utilityAgain
branch
from
43437d8 to
412e909
Compare
|
The PR is OK (basically, you just moved the code to another module). The CI is failing though, but clearly unrelated to these changes, maybe it's another effect of DIRACGrid/diracx#634 ? |
fstagni
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And again !
Something which is in
utilitiesshould be usable by everything (Client,Agent,Services, etc). So can we please stop importing DB inutilities?BEGINRELEASENOTES
*WMS
FIX: Do not import DB at the top of the utility module
ENDRELEASENOTES