Skip to content

[9.0] Avoid endless loop in MonitoringReporter #8363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

[9.0] Avoid endless loop in MonitoringReporter #8363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc6e63d
fix: avoid endless loop in MonitoringReporter
atsareg Nov 3, 2025
4883dba
fix: reset try_count upon a successful document upload
atsareg Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/DIRAC/MonitoringSystem/Client/MonitoringReporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ def commit(self):
self.__documents = []
self.__documentLock.release()
recordSent = 0
try_count = 0
try:
while documents:
recordsToSend = documents[: self.__maxRecordsInABundle]
Expand All @@ -150,8 +151,13 @@ def commit(self):
# if we managed to publish the records we can delete from the list
recordSent += len(recordsToSend)
del documents[: self.__maxRecordsInABundle]
try_count = 0
else:
gLogger.warn("Failed to insert the records:", retVal["Message"])
try_count += 1
if try_count == 10:
gLogger.error("Failed to insert Monitoring records after 10 attempts")
break
Copy link
Member

@chrisburr chrisburr Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should try_count be reset if a bundle is sucessfully sent?

Copy link
Contributor Author

@atsareg atsareg Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

except Exception as e: # pylint: disable=broad-except
gLogger.exception("Error committing", lException=e)
return S_ERROR(f"Error committing {repr(e).replace(',)',')')}")
Expand Down
Loading