-
Notifications
You must be signed in to change notification settings - Fork 1
[NDH-278] Build out OrganizationAffiliation endpoint #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[NDH-278] Build out OrganizationAffiliation endpoint #270
Conversation
…erializer Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…affiliation-endpoint
…affiliation-endpoint
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…affiliation-endpoint
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tests pass but im not getting anything back when i hit the API. im assuming its because their isnt proper data in the db for this endpoint? once this is confirmed and playwright tests pass, i can approve. everything else LGTM
…affiliation-endpoint
spopelka-dsac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be easier to assess the rest of the changes once the test fixtures PR is landed, so that this diff isn't so big. I'll provide further comments once that one is merged
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
…affiliation-endpoint
spopelka-dsac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please focus on the serializer comments and remove filters and sort for OrganizationAffiliaiton. I will create new tickets to add those back in after we get the basic /fhir/OrganizationAffiliation merged.
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
spopelka-dsac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fully move filters and sort to a separate PR? It will make easier to review filter and sort in future PRs when we get to that.
Can you please also delete the commented code in the OrganizationAffiliaition serializer? At this point, I don't anticipate that we will be adding those elements in.
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
[NDH-278] Build out OrganizationAffiliation endpoint
Jira Ticket #NDH-278
Problem
We currently do not have an endpoint that can query OrganizationAffiliation data. This endpoint returns data that represents the affiliation relationship between clinical organizations and EHR Vendors
Additionally, we need to make it so that EHR Vendors can be queried in the Organization view.
Solution
Add a new view set for OrganizationAffiliation data that has list and retrieve endpoints. Also, create a corresponding serializer class that will create FHIR JSON for the data returned.
Additionally, make it so that EHR Vendors can be queried in the Organization viewset.
Tests also need to be created for all this.
Result
Summary:
Test Plan
make test