-
Notifications
You must be signed in to change notification settings - Fork 24
feat: enable evmc vm library build #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - [x] 9.1 Add OpenSpec project structure and configuration | ||
| - [x] 9.2 Create AGENTS.md with AI assistant instructions | ||
| - [x] 9.3 Set up spec-driven development workflow | ||
| - [x] 9.4 Configure change proposal management system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- after I reviewed this PR, you need to openspec.archive this change(after that, the change dir will be moved to openspec/changes/archives and update the openspec/specs
- When creating a PR, do not include openspec.archive. After the code review is basically completed, add openspec.archive as a separate commit to this PR.
- why there are some not marked todo items in tasks.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I created this change using existing commit, so there are some not implemented items in tasks.md, shall I let openspec finish those unmarked items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, use AI to create a TODO-SPECS.md under openspec directory, and mark the status of the features and sub tasks
openspec/project.md
Outdated
| - **Core Language**: C++ (primary implementation) | ||
| - **Runtime Support**: C, Rust APIs | ||
| - **Compilation**: CMake build system | ||
| - **JIT Backend**: LLVM 15 (for Lazy-JIT mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llvm 15 is not jit backend, but we use some base data structures in it
|
lgtm, you can archive this change now |
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note