Open
Conversation
not tested with buffer
In place transform
Implements indirect dispatch
restore some whitespaces Update vkFFT_UpdateBuffers.h remove debug lines remove currentBatch/dynamicBatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements indirect dispatch for the Vulkan backend, which allows to dynamically update the number of batches.
I works through 4 user settable variables in the configuration struct:
The structure of the indirectBuffer is (x_size, y_size, z_size, id) for every dispatch. The number of dispatches per FFT is typically between 1-4. id is an uint that is used to identify the axis that needs to be updated; 0 for x, 1 for y, 2 for z. This is set by VkFFT during the dispatch phase and can be read by the user to determine which workgroup size needs to be modified.
A few points worthy of note: