Open
Conversation
bkmgit
commented
Oct 22, 2022
- Partially addresses CI tests #90
- Can squash commits.
- The precision tests cause a segmentation fault, probably due to memory requirements. Maybe a small set of test cases can be considered?
Compare Pocl code against FFTW
Try to get CI to work as failing because OpenCl library is not found.
Add a missing additional dependency
libopencl is not installed
Owner
|
Hello, Thank you for the effort, I will need to check on how this will work and decide on the small set of tests that can be done in CI (and to automatically decide if accuracy is good) - then it can be done as a separate script file. I think it will be better this way, than just relaunching all precision verification scripts every time. Best regards, |
Author
|
Thanks for the library. Some of the precision failures may be due to the implementations of OpenCl/Vulkan not just the FFT library. Can add other possible backends, in particular llvmpipe and HIP-CPU that can run on CPU once a subset of tests is chosen. These will also be helpful for packaging the library in Linux distributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.