-
-
Notifications
You must be signed in to change notification settings - Fork 3
하차 팀원 관련 업데이트 #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
하차 팀원 관련 업데이트 #744
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -164,35 +164,35 @@ function TeamCard({ member, isDark }: TeamCardProps) { | |
| </Card.Body> | ||
| </HStack> | ||
| <HStack align="right" gap="20" className={css({ width: "100%" })}> | ||
| {githubUrl && ( | ||
| {linkedinUrl && ( | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jj5u 님, 링크드인 핸들을 숨기고 싶은 분들이 계셔서 기존처럼 링크드인 아이콘을 뒤에 배치하기 보다는 앞에 배치하면 좀 더 깔끔해보는 것 같은데 어떻게 생각하시나요?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 네 그런 경우라면 순서 변경하면 좋겠습니다~
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jj5u 님, 답변 감사합니다. 그럼 피그마에도 동일하게 반영 좀 부탁드릴께요. |
||
| <Link | ||
| href={githubUrl} | ||
| href={linkedinUrl} | ||
| external | ||
| underline={false} | ||
| aria-label={`${name}의 GitHub 프로필`} | ||
| aria-label={`${name}의 LinkedIn 프로필`} | ||
| > | ||
| <img | ||
| src={isDark ? githubDarkIcon : githubLightIcon} | ||
| alt="GitHub" | ||
| src={isDark ? linkedInDarkIcon : linkedInLightIcon} | ||
| alt="LinkedIn" | ||
| className={css({ | ||
| width: "14px", | ||
| height: "14px", | ||
| })} | ||
| /> | ||
| </Link> | ||
| )} | ||
| {linkedinUrl && ( | ||
| {githubUrl && ( | ||
| <Link | ||
| href={linkedinUrl} | ||
| href={githubUrl} | ||
| external | ||
| underline={false} | ||
| aria-label={`${name}의 LinkedIn 프로필`} | ||
| aria-label={`${name}의 GitHub 프로필`} | ||
| > | ||
| <img | ||
| src={isDark ? linkedInDarkIcon : linkedInLightIcon} | ||
| alt="LinkedIn" | ||
| src={isDark ? githubDarkIcon : githubLightIcon} | ||
| alt="GitHub" | ||
| className={css({ | ||
| width: "14px", | ||
| height: "14px", | ||
| })} | ||
| /> | ||
| </Link> | ||
|
|
@@ -212,27 +212,27 @@ const Members: TeamMember[] = [ | |
| role: "Engineer", | ||
| flag: "🇨🇦", | ||
| location: "Toronto", | ||
| avatar: "https://avatars.githubusercontent.com/u/5466341", | ||
| githubUrl: "https://github.com/DaleSeo", | ||
| linkedinUrl: "https://www.linkedin.com/in/daleseo/", | ||
| avatar: "https://avatars.githubusercontent.com/u/5466341", | ||
| }, | ||
| { | ||
| name: "Helena", | ||
| role: "Engineer", | ||
| flag: "🇨🇦", | ||
| location: "Toronto", | ||
| avatar: "https://avatars.githubusercontent.com/u/38199103", | ||
| githubUrl: "https://github.com/yolophg", | ||
| linkedinUrl: "https://www.linkedin.com/in/yolophg/", | ||
| avatar: "https://avatars.githubusercontent.com/u/38199103", | ||
| }, | ||
| { | ||
| name: "Evan (에반)", | ||
| role: "Engineer", | ||
| flag: "🇨🇦", | ||
| location: "Toronto", | ||
| avatar: "https://avatars.githubusercontent.com/u/37020415", | ||
| githubUrl: "https://github.com/sounmind", | ||
| linkedinUrl: "https://www.linkedin.com/in/suhyeong-evan-lee/", | ||
| avatar: "https://avatars.githubusercontent.com/u/37020415", | ||
| }, | ||
| { | ||
| name: "hyoseong", | ||
|
|
@@ -252,24 +252,6 @@ const Members: TeamMember[] = [ | |
| githubUrl: "https://github.com/RiaOh", | ||
| linkedinUrl: "https://www.linkedin.com/in/riaoh/", | ||
| }, | ||
| { | ||
| name: "살미", | ||
| role: "Engineer", | ||
| flag: "🇰🇷", | ||
| location: "Seoul", | ||
| githubUrl: "https://github.com/Lustellz", | ||
| linkedinUrl: "https://www.linkedin.com/in/tasha0417/", | ||
| avatar: "https://avatars.githubusercontent.com/u/45252527", | ||
| }, | ||
| { | ||
| name: "은지", | ||
| role: "Engineer", | ||
| flag: "🇰🇷", | ||
| location: "Seoul", | ||
| githubUrl: "https://github.com/y00eunji", | ||
| linkedinUrl: "https://www.linkedin.com/in/y00eunji/", | ||
| avatar: "https://avatars.githubusercontent.com/u/27201591", | ||
| }, | ||
| { | ||
| name: "한샘", | ||
| role: "Engineer", | ||
|
|
@@ -279,32 +261,23 @@ const Members: TeamMember[] = [ | |
| githubUrl: "https://github.com/Hecklebot", | ||
| linkedinUrl: "https://www.linkedin.com/in/hansaem-so/", | ||
| }, | ||
| { | ||
| name: "Aka (아카)", | ||
| role: "Engineer", | ||
| flag: "🇰🇷", | ||
| location: "Seoul", | ||
| githubUrl: "https://github.com/HowToBeAHappyBoy", | ||
| linkedinUrl: "https://www.linkedin.com/in/seozi/", | ||
| avatar: "https://avatars.githubusercontent.com/u/30362922", | ||
| }, | ||
| { | ||
| name: "승현", | ||
| role: "Designer", | ||
| flag: "🇰🇷", | ||
| location: "Seoul", | ||
| avatar: "https://avatars.githubusercontent.com/u/69985950", | ||
| githubUrl: "https://github.com/sseung30", | ||
| linkedinUrl: undefined, | ||
| avatar: "https://avatars.githubusercontent.com/u/69985950", | ||
| }, | ||
| { | ||
| name: "자혜", | ||
| role: "Designer", | ||
| flag: "🇰🇷", | ||
| location: "Seoul", | ||
| avatar: "https://avatars.githubusercontent.com/u/89135410", | ||
| githubUrl: "https://github.com/jj5u", | ||
| linkedinUrl: undefined, | ||
| avatar: "https://avatars.githubusercontent.com/u/89135410", | ||
| }, | ||
| ]; | ||
|
|
||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sounmind 블로그 발행하셨다고 치고, 훈장 추가하였습니다. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다!