Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"name": "Evan Suhyeong Lee",
"avatar_url": "https://avatars.githubusercontent.com/u/37020415?v=4",
"profile": "https://github.com/sounmind",
"contributions": ["code", "doc"]
"contributions": ["blog", "code", "doc"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounmind 블로그 발행하셨다고 치고, 훈장 추가하였습니다. 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

},
{
"login": "hyoseong1994",
Expand All @@ -40,34 +40,13 @@
"profile": "https://github.com/RiaOh",
"contributions": ["code", "doc"]
},
{
"login": "Lustellz",
"name": "Tasha(살미)",
"avatar_url": "https://avatars.githubusercontent.com/u/45252527?v=4",
"profile": "https://github.com/Lustellz",
"contributions": ["code", "doc"]
},
{
"login": "y00eunji",
"name": "유은지",
"avatar_url": "https://avatars.githubusercontent.com/u/27201591?v=4",
"profile": "https://github.com/y00eunji",
"contributions": ["code", "doc"]
},
{
"login": "Hecklebot",
"name": "Hansaem.so",
"avatar_url": "https://avatars.githubusercontent.com/u/51806574?v=4",
"profile": "https://velog.io/@hecklebot",
"contributions": ["code", "doc"]
},
{
"login": "HowToBeAHappyBoy",
"name": "서진혁 (Aka)",
"avatar_url": "https://avatars.githubusercontent.com/u/30362922?v=4",
"profile": "https://seozi.io/",
"contributions": ["code", "doc"]
},
{
"login": "sseung30",
"name": "seunghyun",
Expand All @@ -82,6 +61,27 @@
"profile": "https://github.com/jj5u",
"contributions": ["design"]
},
{
"login": "HowToBeAHappyBoy",
"name": "서진혁 (Aka)",
"avatar_url": "https://avatars.githubusercontent.com/u/30362922?v=4",
"profile": "https://seozi.io/",
"contributions": ["code", "doc"]
},
{
"login": "y00eunji",
"name": "유은지",
"avatar_url": "https://avatars.githubusercontent.com/u/27201591?v=4",
"profile": "https://github.com/y00eunji",
"contributions": ["code", "doc"]
},
{
"login": "Lustellz",
"name": "Tasha(살미)",
"avatar_url": "https://avatars.githubusercontent.com/u/45252527?v=4",
"profile": "https://github.com/Lustellz",
"contributions": ["code", "doc"]
},
{
"login": "boldkang",
"name": "mkang",
Expand Down
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

## Contributors ✨

프로젝트는 [all-contributors](https://github.com/all-contributors/all-contributors) 스펙을 따릅니다. 모든 종류의 기여를 환영합니다!
프로젝트는 [All Contributors](https://github.com/all-contributors/all-contributors) 관례에 따라 기여자분들의 공헌를 인정하고 감사를 표현하고 있습니다.

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore-start -->
Expand All @@ -24,17 +24,17 @@
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://www.daleseo.com/"><img src="https://avatars.githubusercontent.com/u/5466341?v=4?s=100" width="100px;" alt="Dale Seo"/><br /><sub><b>Dale Seo</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=DaleSeo" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=DaleSeo" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/yolophg"><img src="https://avatars.githubusercontent.com/u/38199103?v=4?s=100" width="100px;" alt="Helena Park"/><br /><sub><b>Helena Park</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=yolophg" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=yolophg" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/sounmind"><img src="https://avatars.githubusercontent.com/u/37020415?v=4?s=100" width="100px;" alt="Evan Suhyeong Lee"/><br /><sub><b>Evan Suhyeong Lee</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=sounmind" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=sounmind" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/sounmind"><img src="https://avatars.githubusercontent.com/u/37020415?v=4?s=100" width="100px;" alt="Evan Suhyeong Lee"/><br /><sub><b>Evan Suhyeong Lee</b></sub></a><br /><a href="#blog-sounmind" title="Blogposts">📝</a> <a href="https://github.com/DaleStudy/daleui/commits?author=sounmind" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=sounmind" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/hyoseong1994"><img src="https://avatars.githubusercontent.com/u/50227228?v=4?s=100" width="100px;" alt="hyoseong"/><br /><sub><b>hyoseong</b></sub></a><br /><a href="#blog-hyoseong1994" title="Blogposts">📝</a> <a href="https://github.com/DaleStudy/daleui/commits?author=hyoseong1994" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=hyoseong1994" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/RiaOh"><img src="https://avatars.githubusercontent.com/u/83909755?v=4?s=100" width="100px;" alt="오예림 Ria Oh"/><br /><sub><b>오예림 Ria Oh</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=RiaOh" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=RiaOh" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/Lustellz"><img src="https://avatars.githubusercontent.com/u/45252527?v=4?s=100" width="100px;" alt="Tasha(살미)"/><br /><sub><b>Tasha(살미)</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=Lustellz" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=Lustellz" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/y00eunji"><img src="https://avatars.githubusercontent.com/u/27201591?v=4?s=100" width="100px;" alt="유은지"/><br /><sub><b>유은지</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=y00eunji" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=y00eunji" title="Documentation">📖</a></td>
</tr>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://velog.io/@hecklebot"><img src="https://avatars.githubusercontent.com/u/51806574?v=4?s=100" width="100px;" alt="Hansaem.so"/><br /><sub><b>Hansaem.so</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=Hecklebot" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=Hecklebot" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://seozi.io/"><img src="https://avatars.githubusercontent.com/u/30362922?v=4?s=100" width="100px;" alt="서진혁 (Aka)"/><br /><sub><b>서진혁 (Aka)</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=HowToBeAHappyBoy" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=HowToBeAHappyBoy" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/sseung30"><img src="https://avatars.githubusercontent.com/u/69985950?v=4?s=100" width="100px;" alt="seunghyun"/><br /><sub><b>seunghyun</b></sub></a><br /><a href="#design-sseung30" title="Design">🎨</a></td>
</tr>
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/jj5u"><img src="https://avatars.githubusercontent.com/u/89135410?v=4?s=100" width="100px;" alt="Jahye"/><br /><sub><b>Jahye</b></sub></a><br /><a href="#design-jj5u" title="Design">🎨</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://seozi.io/"><img src="https://avatars.githubusercontent.com/u/30362922?v=4?s=100" width="100px;" alt="서진혁 (Aka)"/><br /><sub><b>서진혁 (Aka)</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=HowToBeAHappyBoy" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=HowToBeAHappyBoy" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/y00eunji"><img src="https://avatars.githubusercontent.com/u/27201591?v=4?s=100" width="100px;" alt="유은지"/><br /><sub><b>유은지</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=y00eunji" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=y00eunji" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/Lustellz"><img src="https://avatars.githubusercontent.com/u/45252527?v=4?s=100" width="100px;" alt="Tasha(살미)"/><br /><sub><b>Tasha(살미)</b></sub></a><br /><a href="https://github.com/DaleStudy/daleui/commits?author=Lustellz" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=Lustellz" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/boldkang"><img src="https://avatars.githubusercontent.com/u/202710030?v=4?s=100" width="100px;" alt="mkang"/><br /><sub><b>mkang</b></sub></a><br /><a href="#blog-boldkang" title="Blogposts">📝</a> <a href="#design-boldkang" title="Design">🎨</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://sunjae95.github.io/"><img src="https://avatars.githubusercontent.com/u/63578094?v=4?s=100" width="100px;" alt="이선재"/><br /><sub><b>이선재</b></sub></a><br /><a href="#blog-Sunjae95" title="Blogposts">📝</a> <a href="https://github.com/DaleStudy/daleui/commits?author=Sunjae95" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=Sunjae95" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://sehwanlee.dev/"><img src="https://avatars.githubusercontent.com/u/39740066?v=4?s=100" width="100px;" alt="Sehwan"/><br /><sub><b>Sehwan</b></sub></a><br /><a href="#blog-nhistory" title="Blogposts">📝</a> <a href="https://github.com/DaleStudy/daleui/commits?author=nhistory" title="Code">💻</a> <a href="https://github.com/DaleStudy/daleui/commits?author=nhistory" title="Documentation">📖</a></td>
Expand Down
59 changes: 16 additions & 43 deletions src/marketing/Team.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -164,35 +164,35 @@ function TeamCard({ member, isDark }: TeamCardProps) {
</Card.Body>
</HStack>
<HStack align="right" gap="20" className={css({ width: "100%" })}>
{githubUrl && (
{linkedinUrl && (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jj5u 님, 링크드인 핸들을 숨기고 싶은 분들이 계셔서 기존처럼 링크드인 아이콘을 뒤에 배치하기 보다는 앞에 배치하면 좀 더 깔끔해보는 것 같은데 어떻게 생각하시나요?

  • Before
Image
  • After
Image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 그런 경우라면 순서 변경하면 좋겠습니다~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jj5u 님, 답변 감사합니다. 그럼 피그마에도 동일하게 반영 좀 부탁드릴께요.

<Link
href={githubUrl}
href={linkedinUrl}
external
underline={false}
aria-label={`${name}의 GitHub 프로필`}
aria-label={`${name}의 LinkedIn 프로필`}
>
<img
src={isDark ? githubDarkIcon : githubLightIcon}
alt="GitHub"
src={isDark ? linkedInDarkIcon : linkedInLightIcon}
alt="LinkedIn"
className={css({
width: "14px",
height: "14px",
})}
/>
</Link>
)}
{linkedinUrl && (
{githubUrl && (
<Link
href={linkedinUrl}
href={githubUrl}
external
underline={false}
aria-label={`${name}의 LinkedIn 프로필`}
aria-label={`${name}의 GitHub 프로필`}
>
<img
src={isDark ? linkedInDarkIcon : linkedInLightIcon}
alt="LinkedIn"
src={isDark ? githubDarkIcon : githubLightIcon}
alt="GitHub"
className={css({
width: "14px",
height: "14px",
})}
/>
</Link>
Expand All @@ -212,27 +212,27 @@ const Members: TeamMember[] = [
role: "Engineer",
flag: "🇨🇦",
location: "Toronto",
avatar: "https://avatars.githubusercontent.com/u/5466341",
githubUrl: "https://github.com/DaleSeo",
linkedinUrl: "https://www.linkedin.com/in/daleseo/",
avatar: "https://avatars.githubusercontent.com/u/5466341",
},
{
name: "Helena",
role: "Engineer",
flag: "🇨🇦",
location: "Toronto",
avatar: "https://avatars.githubusercontent.com/u/38199103",
githubUrl: "https://github.com/yolophg",
linkedinUrl: "https://www.linkedin.com/in/yolophg/",
avatar: "https://avatars.githubusercontent.com/u/38199103",
},
{
name: "Evan (에반)",
role: "Engineer",
flag: "🇨🇦",
location: "Toronto",
avatar: "https://avatars.githubusercontent.com/u/37020415",
githubUrl: "https://github.com/sounmind",
linkedinUrl: "https://www.linkedin.com/in/suhyeong-evan-lee/",
avatar: "https://avatars.githubusercontent.com/u/37020415",
},
{
name: "hyoseong",
Expand All @@ -252,24 +252,6 @@ const Members: TeamMember[] = [
githubUrl: "https://github.com/RiaOh",
linkedinUrl: "https://www.linkedin.com/in/riaoh/",
},
{
name: "살미",
role: "Engineer",
flag: "🇰🇷",
location: "Seoul",
githubUrl: "https://github.com/Lustellz",
linkedinUrl: "https://www.linkedin.com/in/tasha0417/",
avatar: "https://avatars.githubusercontent.com/u/45252527",
},
{
name: "은지",
role: "Engineer",
flag: "🇰🇷",
location: "Seoul",
githubUrl: "https://github.com/y00eunji",
linkedinUrl: "https://www.linkedin.com/in/y00eunji/",
avatar: "https://avatars.githubusercontent.com/u/27201591",
},
{
name: "한샘",
role: "Engineer",
Expand All @@ -279,32 +261,23 @@ const Members: TeamMember[] = [
githubUrl: "https://github.com/Hecklebot",
linkedinUrl: "https://www.linkedin.com/in/hansaem-so/",
},
{
name: "Aka (아카)",
role: "Engineer",
flag: "🇰🇷",
location: "Seoul",
githubUrl: "https://github.com/HowToBeAHappyBoy",
linkedinUrl: "https://www.linkedin.com/in/seozi/",
avatar: "https://avatars.githubusercontent.com/u/30362922",
},
{
name: "승현",
role: "Designer",
flag: "🇰🇷",
location: "Seoul",
avatar: "https://avatars.githubusercontent.com/u/69985950",
githubUrl: "https://github.com/sseung30",
linkedinUrl: undefined,
avatar: "https://avatars.githubusercontent.com/u/69985950",
},
{
name: "자혜",
role: "Designer",
flag: "🇰🇷",
location: "Seoul",
avatar: "https://avatars.githubusercontent.com/u/89135410",
githubUrl: "https://github.com/jj5u",
linkedinUrl: undefined,
avatar: "https://avatars.githubusercontent.com/u/89135410",
},
];

Expand Down