Open
Conversation
- Change default tone from "neutral" to "brand" to match Figma use_case - Apply tone-specific colors to checked state (border and dot) - Add hint prop for auxiliary label text (e.g. "옵션 선택") - Adjust vertical gap from 8px to 9px per Figma spec - Add 4px padding to Radio items matching Checkbox component
sounmind
force-pushed
the
755-radio-figma-alignment
branch
from
a0838fd to
b4ef458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #755
코멘트의 1번, 2번, 5번, 6번, 7번 항목을 코드 수정으로 해결합니다.
"neutral"→"brand"로 변경 (Figma use_case 및 Checkbox 컴포넌트와 일치)hintprop 추가 (라벨 옆 보조 텍스트, e.g. "옵션 선택")테스팅
bun run lint— 0 errorsbun run test— 473 tests passedbun run build— 빌드 성공체크 리스트