-
-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade Storybook to v10 #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Updated all @storybook/* packages to 9.0.0 - Updated @chromatic-com/storybook to 3.2.2 - Updated @storybook/test-runner to 0.21.0 - No configuration changes required - existing configs are compatible Co-authored-by: Dale Seo <[email protected]>
DaleSeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storybook-test.yml에서
storybook build -> 로컬 serve -> 로컬 타켓 테스트
로 변경하였습니다.
조치는 이해가 되는데 이슈가 왜 발생하는지 잘 이해가 안 되는데 원인 분석을 해보셨을까요? 혹시 현재 이번달 Chromatic 무료 사용량을 다 소진해서 그런 걸까요?
| "@storybook/addon-docs": "^10.1.11", | ||
| "@storybook/test-runner": "^0.24.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 package.json을 직접 수정하셨나요? 알파벳 순으로 정렬이 되어 있지 않아서요.
| env: | ||
| TARGET_URL: "${{ github.event.deployment_status.environment_url }}" | ||
| - run: bun run build-storybook | ||
| - run: yes | bunx serve storybook-static -l 6006 & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes가 왜 필요한 거에요?
|
|
||
| const config: StorybookConfig = { | ||
| stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"], | ||
| stories: ["../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 mdx 스토리가 없더라도 "../src/**/*.mdx"를 제거하시면 안 될 것 같습니다. 나중에 mdx 스토리를 추가했을 때 왜 안 되는지 영문을 모를 것 같아요.
Summary
Upgrades Storybook from 8.6.12 to 9.0.0 as requested in issue #239.
Changes
@storybook/*packages to 9.0.0@chromatic-com/storybookto 3.2.2@storybook/test-runnerto 0.21.0issue
유효한 URL임에도 불구하고 "Are you sure it's running?" 오류가 발생
302 로그인 페이지로 리디렉션
storybook-test.yml에서storybook build -> 로컬 serve -> 로컬 타켓 테스트
로 변경하였습니다.
Closes #239
Generated with Claude Code