Open
Conversation
Owner
|
This seems nice, thanks ! I would rather give it a try on my system before merging, but currently my ISP is down and should only be back up in more than a month (it's been two month already). 😓 Don't hesitate to ping me mid-may if you see the merge still open by then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I had this idea to try and fix issue #18.
This is my first contribution on a public repo so I'm open to anything you'd have to say !
I tested the code and it works great but I'm kind of worried of how it would react if the "main record" used to get the "dns_ip" variable is not of type "A" (Although I can't think of a use case were you would want to update a TXT record without changing another A record).
A solution could be to make sure "config['dns']['records']" isn't empty ?
Let me know what you think :)