Rename files.url to files.azul_file_url for AnVIL (#6549) #7568

dsotirho-ucsc · 2025-11-12T18:51:09Z

Linked issues: #6549

Checklist

NOTES

This should be merged together with Service Lambda memory oversized #7432, see bottom of Service Lambda memory oversized #7432 (comment) as to why.

Author

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all linked issues}
This PR partially resolves each of the linked issues _{or does not have the partial label}

Author (reindex)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}

Author (API changes)

This PR and its linked issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any linked issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues linked to this PR}

Author (before every review)

Rebased PR branch on develop, squashed fixups from prior reviews
Ran make requirements_update _{or this PR does not modify Dockerfile, environment, requirements*.txt, common.mk, Makefile or environment.boot}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}
PR is awaiting requested review from a peer
Status of PR is Review requested
PR is assigned to ~~only~~ the peer

Peer reviewer (after approval)

Note that when requesting changes, the PR must be assigned back to the author.

Actually approved the PR
PR is not a draft
PR is awaiting requested review from system administrator
Status of PR is Review requested
PR is assigned to ~~only~~ the system administrator

System administrator (after approval)

Actually approved the PR
Labeled linked issues as demo or no demo
Commented on linked issues about demo expectations _{or all linked issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Status of PR is Approved
PR is assigned to ~~only~~ the operator

Operator

Checked reindex:… labels and r commit title tag
Checked that demo expectations are clear _{or all linked issues are labeled no demo}
Squashed PR branch and rebased onto develop
Sanity-checked history
Pushed PR branch to GitHub

Operator (deploy `.shared` and `.gitlab` components)

Ran _select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Ran _select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Checked the items in the next section _{or this PR is labeled deploy:gitlab}
PR is assigned to ~~only~~ the system administrator _{or this PR is not labeled deploy:gitlab}

System administrator (post-deploy of `.gitlab` component)

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to ~~only~~ the operator

Operator (deploy runner image)

Ran _select dev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
Ran _select anvildev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}

Operator (sandbox build)

Operator (merge the branch)

All status checks passed and the PR is mergeable
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but only included p if the PR is also labeled partial}
Pushed merge commit to GitHub
Status of PR is Merged lower
Status of blocked issues is Triage _{or no issues are blocked on the linked issues}

Operator (main build)

Operator (reindex)

Operator (mirroring)

Started mirroring in dev _{or this PR does not require mirroring dev}
Started mirroring in anvildev _{or this PR does not require mirroring anvildev}
Checked for, triaged and possibly requeued messages in mirror fail queue in dev _{or this PR does not require mirroring dev}
Checked for, triaged and possibly requeued messages in mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}
Emptied mirror fail queue in dev _{or this PR does not require mirroring dev}
Emptied mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

codecov · 2025-11-13T17:38:24Z

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.27%. Comparing base (fcb3ab2) to head (e30bc43).
⚠️ Report is 23 commits behind head on develop.

Files with missing lines	Patch %	Lines
test/integration_test.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7568      +/-   ##
===========================================
- Coverage    85.27%   85.27%   -0.01%     
===========================================
  Files          156      156              
  Lines        22531    22529       -2     
===========================================
- Hits         19213    19211       -2     
  Misses        3318     3318

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coveralls · 2025-11-13T17:39:37Z

coverage: 85.488% (-0.001%) from 85.489%
when pulling e30bc43 on issues/dsotirho-ucsc/6549-rename-anvil-fields-2
into fcb3ab2 on develop.

hannes-ucsc · 2025-11-13T18:50:17Z

lambdas/service/app.py

        # the minor version for backwards compatible changes. A backwards
        # compatible change is one that does not require updates to clients.
-        'version': '14.4',
+        'version': '14.5',


This is a backwards incompatible change.

dsotirho-ucsc · 2025-11-13T19:26:15Z

7568_IT_2025-11-13.txt

achave11-ucsc

Approved ✅

hannes-ucsc

Looks good. Please hold warm. Re-request review for this PR when requesting review for PR against #7432.

dsotirho-ucsc linked an issue Nov 12, 2025 that may be closed by this pull request

Rename files.url to files.azul_file_url for AnVIL #6549

Open

dsotirho-ucsc self-assigned this Nov 12, 2025

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/6549-rename-anvil-fields-2 branch 4 times, most recently from a4ba308 to fd27dab Compare November 13, 2025 17:22

hannes-ucsc mentioned this pull request Nov 13, 2025

Service Lambda memory oversized #7432

Open

hannes-ucsc requested changes Nov 13, 2025

View reviewed changes

[A] Remove files.url (#6549)

e30bc43

dsotirho-ucsc force-pushed the issues/dsotirho-ucsc/6549-rename-anvil-fields-2 branch from fd27dab to e30bc43 Compare November 13, 2025 18:55

dsotirho-ucsc requested a review from achave11-ucsc November 13, 2025 19:26

dsotirho-ucsc assigned achave11-ucsc Nov 13, 2025

achave11-ucsc approved these changes Nov 13, 2025

View reviewed changes

achave11-ucsc marked this pull request as ready for review November 13, 2025 22:55

achave11-ucsc assigned hannes-ucsc and unassigned achave11-ucsc Nov 13, 2025

achave11-ucsc requested a review from hannes-ucsc November 13, 2025 22:56

hannes-ucsc approved these changes Nov 18, 2025

View reviewed changes

hannes-ucsc reviewed Nov 18, 2025

View reviewed changes

hannes-ucsc added the hold warm [process] PR can't land just yet but needs to be rebased daily label Nov 18, 2025

hannes-ucsc removed their assignment Nov 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename files.url to files.azul_file_url for AnVIL (#6549) #7568

Rename files.url to files.azul_file_url for AnVIL (#6549) #7568

Uh oh!

dsotirho-ucsc commented Nov 12, 2025 •

edited by hannes-ucsc

Loading

Uh oh!

codecov bot commented Nov 13, 2025 •

edited

Loading

Uh oh!

coveralls commented Nov 13, 2025 •

edited

Loading

Uh oh!

hannes-ucsc Nov 13, 2025

Uh oh!

dsotirho-ucsc commented Nov 13, 2025

Uh oh!

achave11-ucsc left a comment

Uh oh!

hannes-ucsc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rename files.url to files.azul_file_url for AnVIL (#6549) #7568

Are you sure you want to change the base?

Rename files.url to files.azul_file_url for AnVIL (#6549) #7568

Uh oh!

Conversation

dsotirho-ucsc commented Nov 12, 2025 • edited by hannes-ucsc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

NOTES

Author

Author (partiality)

Author (reindex)

Author (API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator

Operator (deploy .shared and .gitlab components)

System administrator (post-deploy of .gitlab component)

Operator (deploy runner image)

Operator (sandbox build)

Operator (merge the branch)

Operator (main build)

Operator (reindex)

Operator (mirroring)

Operator

Shorthand for review comments

Uh oh!

codecov bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hannes-ucsc Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

dsotirho-ucsc commented Nov 13, 2025

Uh oh!

achave11-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

hannes-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dsotirho-ucsc commented Nov 12, 2025 •

edited by hannes-ucsc

Loading

Operator (deploy `.shared` and `.gitlab` components)

System administrator (post-deploy of `.gitlab` component)

codecov bot commented Nov 13, 2025 •

edited

Loading

coveralls commented Nov 13, 2025 •

edited

Loading