Skip to content

Conversation

@rushtong
Copy link
Contributor

@rushtong rushtong commented Jan 26, 2024

Addresses

TODO

Summary

This is a rough first pass/proof of concept at trying to generate a compliant GA4GH passport implementation.

TODO

Things that we need to review for achieving compliance:

  • Request a ga4gh_passport_v1 scope for all passport requests
  • Encoded JWTs The spec requires that: "Visas are signed JWTs encoded into strings using JWS Compact Serialization". This PR provides a decoded version for demonstration purposes.
  • Complete the currently unimplemented claim types:
    • AcceptedTermsAndPolicies
    • LinkedIdentities
  • ResearcherStatus: We need to provide a URL Claim to describe a researcher
  • AffiliationAndRole: Investigate the domain value we're using now

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong changed the title Gr passports WIP: Passports Jan 26, 2024
@rushtong
Copy link
Contributor Author

@dependabot show ignore conditions

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2025

# Conflicts:
#	src/main/java/org/broadinstitute/consent/http/ConsentApplication.java
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants