-
Notifications
You must be signed in to change notification settings - Fork 4
DT-2039: associated labels for accessibility compliance #3047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos on your first DUOS PR!
Code looks generally good, but the duplicate config.json
and linting issues seem worth fixing. FWIW, I often run npx eslint
before pushing to surface formatting issues locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Let us know if you need help addressing the lint warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates. I do see that some of the original feedback has not been applied yet:
- Changes to
base_config.json
should be reverted PaginatorBar.jsx
should be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment inline. It is preferable not to change the layout in any way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below:
This PR seems to have been reduced in scope significantly to the point that removing |
@rushtong just so I am clear, you'd like a separate PR for deleting PaginatorBar.jsx. Adding that file back in this PR so that it is only captured in the future PR? Am I following that correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rushtong, Austin has a question on how to proceed.
Please re-request review when this is ready for another round -- happy to take a look!
Thanks for the reminder, I'll take another look. |
@brack2891 - Yes, exactly. In general, the PR should be focused on the required changes and that file deletion is essentially unrelated. By tying PRs to tickets, we can better track why something happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below:
380d638
to
3e41375
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't yet have an e2e github action so these tests are not run on PRs. When I run this locally, there are a number of failing tests. How did you get these to succeed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing failing tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file isn't used by any other components so it is essentially untestable. Changes here should be reverted and the file removed in a separate cleanup PR.
Addresses
https://broadworkbench.atlassian.net/browse/DT-2039
Summary
Adding proper clarity to speak to text option within: Research Console, Data Library, and Profile
Have you read Terra's Contributing Guide lately? If not, do that first.