[DC-1804] TDR UI add select billing profile to filtered snapshot create flow #1841
+913
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjohanek
requested review from
calypsomatic and
davidangb
and removed request for
a team
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
rj/dc-1804-add-billing-profile-selection
|
| Run status |
|
| Run duration | 02m 42s |
| Commit |
|
| Committer | Rae Johanek |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
|
holding off on review until this is passing all checks. |
davidangb
approved these changes
Oct 31, 2025
davidangb
left a comment
davidangb
left a comment
There was a problem hiding this comment.
one kinda-question inline, giving this a 👍. I don't know how to realistically test this myself, and there's a lot of change here ... trusting your testing of this!
| (profile) => profile.id === dataset.defaultProfileId, | ||
| ); | ||
| this.setState({ | ||
| selectedBillingProfile: defaultBillingProfile || billingProfiles[0], |
There was a problem hiding this comment.
is there any chance that billingProfiles is completely empty? Would that cause a problem?
EDIT: I see you have a should handle empty billing profiles array unit test, so I'm going to assume this is ok
|
calypsomatic
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DC-1804
User requests for ability to change the billing profile for a filtered snapshot
Summary of Changes
Create reusable component for both the full view snapshot modal and the filtered snapshot panel
Wire in billing to the snapshot create calls to the back end
Update logic for disabling the next button (any billing profiles accessible)
Testing
Adds component tests for new BillingProfileDropdown component
Adds component tests for the CreateSnapshotPanel
Manually tested in the UI, videos here: https://drive.google.com/drive/folders/1Bf_Pl3RafPWwyeL3cRQfQ4Y7N2Qtkzxk?usp=sharing