Prevent telemetry crash from leaking exception #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception happens after telemetry has been sent but before returning from `main`'s `begin`..`end` block, two telemetry events may be emitted, which contradicts the "one start" => "one conclusion" design. Therefore: - tighten exception catching around injection in `main` - prevent telemetry from bubbling an exception up (we can't do anything in this case anyway)
lloeki
force-pushed
the
lloeki/improve-exception-handling
branch
from
5f62a26 to
48eaf0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
main'sbegin..endblock, two telemetry events may be emitted, which contradicts the "one start" => "one conclusion" design.context.statuscould raise exceptions in some situationsguard.callmay raise an exception but that's very unlikelyWhat does this PR do?
mainHow to test the change?
CI
Additional Notes: