Skip to content

Conversation

aureleoules
Copy link
Member

@aureleoules aureleoules commented Mar 6, 2025

What does this PR do?

A brief description of the change being made with this pull request.

Disable mounting /etc/passwd in node agent containers for Talos nodes.

Tested with:

kind: "DatadogAgent"
spec:
  ...
  features:
    logCollection:
      enabled: true
      containerCollectAll: true
    orchestratorExplorer:
      enabled: true
    liveProcessCollection:
      enabled: true
# operator values.yaml
introspection:
  enabled: true # required to detect talos

Motivation

What inspired you to submit this pull request?

DataDog/helm-charts#273 (comment)

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@aureleoules aureleoules force-pushed the aurele.oules/talos branch 4 times, most recently from d4029d2 to 45b5302 Compare March 6, 2025 21:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.47%. Comparing base (54ed549) to head (c2abbce).
Report is 148 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kubernetes/provider.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1765   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files         219      219           
  Lines       21356    21359    +3     
=======================================
+ Hits        10565    10568    +3     
  Misses      10245    10245           
  Partials      546      546           
Flag Coverage Δ
unittests 49.47% <96.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...al/controller/datadogagent/feature/cspm/feature.go 75.20% <100.00%> (ø)
...nal/controller/datadogagent/feature/cws/feature.go 79.55% <100.00%> (ø)
...roller/datadogagent/feature/liveprocess/feature.go 92.07% <100.00%> (ø)
...r/datadogagent/feature/processdiscovery/feature.go 90.00% <100.00%> (ø)
pkg/kubernetes/provider.go 84.82% <85.71%> (+0.41%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ed549...c2abbce. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aureleoules aureleoules added enhancement New feature or request qa/skip-qa labels Mar 6, 2025
@aureleoules aureleoules changed the title talos Do not mount /etc/passwd on Talos nodes Mar 6, 2025
@aureleoules aureleoules marked this pull request as ready for review March 6, 2025 23:46
@aureleoules aureleoules requested a review from a team as a code owner March 6, 2025 23:46
@jonstacks jonstacks mentioned this pull request May 18, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants