-
Notifications
You must be signed in to change notification settings - Fork 126
Alessandro/autopilot introspection #2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alessandro-avendano
wants to merge
51
commits into
main
Choose a base branch
from
alessandro/autopilot-introspection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add eks configmaps (tested locally with dda extraConfd) * fix configmap indentation * add eks configmap to store * fix multi-node bug, prioritize non-default provider * nit * cleanup logger * cleanup single provider for DCA * fix multiple DCA deployment bug
…ection and not experimental labels
…d openshift the legacy daemonset (with name `datadog-agent`) will get created when introspection detects nodes on EKS or Openshift.
already implemented in reconcileInstanceV2 as provider detection is needed in manageDependencies
…utopilot-introspection
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
instead of the experimental annotation needed for gke autopilot support, introspection now has gke autopilot as a provider
Motivation
What inspired you to submit this pull request?
Additional Notes
the label i used was
cloud.google.com/gke-container-runtime
with the value beingcontainerd
based off of what i saw in https://cloud.google.com/kubernetes-engine/docs/concepts/node-images#cos-variants. there are still some small code clean ups that can be made in provider.go, but what is currently in the branch worksMinimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Create a custom image of the operator
Deploy the operator on a GKE autopilot cluster
Apply the following dda manifest
You should be able to see the agent ds runnning with the init-containers, core-agent container, trace-agent container, and process-agent container in the agent ds. You should also be able to see the cluster agent and cluster checks runner
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label