Skip to content

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Sep 22, 2025

What does this PR do?

Add deprecation logs when runProcessChecksInCoreAgent is enabled and centralized documentation for deprecated configs.

Motivation

Deprecation process for #2178

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • build and deploy custom operator image
  • apply a DDA config with runProcessChecksInCoreAgent enabled
  • look into operator logs, verify that a deprecation notice error log is there:
{"level":"ERROR","ts":"2025-09-22T17:07:26.393Z","logger":"controllers.DatadogAgent","msg":"DEPRECATION WARNING: The 'runProcessChecksInCoreAgent' configuration will be deprecated in v1.21. This field can be safely removed with no behavior change.","datadogagent":{"name":"datadog","namespace":"system"},"stacktrace":"github.com/DataDog/datadog-operator/internal/controller/datadogagent.(*Reconciler).internalReconcileV2\n\t/workspace/internal/controller/datadogagent/controller_reconcile_v2.go:45\ngithub.com/DataDog/datadog-operator/internal/controller/datadogagent.(*Reconciler).Reconcile\n\t/workspace/internal/controller/datadogagent/controller.go:106\ngithub.com/DataDog/datadog-operator/internal/controller.(*DatadogAgentReconciler).Reconcile\n\t/workspace/internal/controller/datadogagent_controller.go:188\nsigs.k8s.io/controller-runtime/pkg/reconcile.(*objectReconcilerAdapter[...]).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/reconcile/reconcile.go:154\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:334\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:294\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:255"}

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@swang392 swang392 added this to the v1.19.0 milestone Sep 22, 2025
@swang392 swang392 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.83%. Comparing base (7e19847) to head (7de9493).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2195   +/-   ##
=======================================
  Coverage   38.82%   38.83%           
=======================================
  Files         254      254           
  Lines       26097    26100    +3     
=======================================
+ Hits        10132    10135    +3     
  Misses      15356    15356           
  Partials      609      609           
Flag Coverage Δ
unittests 38.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/controller_reconcile_v2.go 58.62% <100.00%> (+0.54%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e19847...7de9493. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swang392 swang392 marked this pull request as ready for review September 22, 2025 17:32
@swang392 swang392 requested review from a team as code owners September 22, 2025 17:32
@swang392 swang392 merged commit 5e68218 into main Sep 23, 2025
22 checks passed
@swang392 swang392 deleted the swang392/deprecation-notice branch September 23, 2025 19:17
dd-octo-sts bot pushed a commit that referenced this pull request Sep 23, 2025
* error logs for `runProcessChecksInCoreAgent` deprecation

* deprecation table docs

* update from feedback

* clarify deprecation vs removal

* add url to error log

* add deprecation to crd

* documentation fixes

(cherry picked from commit 5e68218)
swang392 added a commit that referenced this pull request Sep 23, 2025
* error logs for `runProcessChecksInCoreAgent` deprecation

* deprecation table docs

* update from feedback

* clarify deprecation vs removal

* add url to error log

* add deprecation to crd

* documentation fixes

(cherry picked from commit 5e68218)

Co-authored-by: Sarah Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.19 documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants