Skip to content

Conversation

tbavelier
Copy link
Member

@tbavelier tbavelier commented Sep 26, 2025

What does this PR do?

  • Adds API-server validation to limit DDA and DAP name lengths to 34 and 57 respectively

Motivation

  • We derive labels/names from these, and labels in k8s are limited to 63 characters. A longer value prevents the object from being re-conciled, which appears in the operator as an error log. Let's instead error out at object creation time so it's more user apparent:
image

Additional Notes

  • The DDA name is limited by the metrics-server service from cluster agent, using DDA name + cluster-agent-metrics-server
  • The DAP name is limited by the -agent suffix once metadata update is rolled out

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added this to the v1.20.0 milestone Sep 26, 2025
@tbavelier tbavelier requested a review from a team as a code owner September 26, 2025 13:57
@tbavelier tbavelier added enhancement New feature or request qa/skip-qa labels Sep 26, 2025
@tbavelier tbavelier changed the title Add validation on DDA and DAP name length [AGENTONB-2550] Add validation on DDA and DAP name length Sep 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.07%. Comparing base (5fddea2) to head (7772d4e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2205   +/-   ##
=======================================
  Coverage   39.07%   39.07%           
=======================================
  Files         253      253           
  Lines       26054    26054           
=======================================
  Hits        10180    10180           
  Misses      15267    15267           
  Partials      607      607           
Flag Coverage Δ
unittests 39.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fddea2...7772d4e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier tbavelier modified the milestones: v1.20.0, v1.21.0 Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants