Skip to content

[Phase 2] chore(trace-exporter): enable data pipeline on Windows #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[Phase 2] chore(trace-exporter): enable data pipeline on Windows #7424

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b541aa
chore(trace-exporter): enable data pipeline based on Windows
Aug 20, 2025
457c343
fix: change log warnings to information for data pipeline disabling
Aug 20, 2025
24c390f
refactor(FrameworkDescription): remove IsLinux method
Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tracer/src/Datadog.Trace/Configuration/TracerSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te

DataPipelineEnabled = config
.WithKeys(ConfigurationKeys.TraceDataPipelineEnabled)
.AsBool(defaultValue: false);
.AsBool(defaultValue: FrameworkDescription.Instance.IsWindows());

if (DataPipelineEnabled)
{
Expand All @@ -420,7 +420,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te
if (StatsComputationEnabled)
{
DataPipelineEnabled = false;
Log.Warning(
Log.Information(
$"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but {ConfigurationKeys.StatsComputationEnabled} is enabled. Disabling data pipeline.");
_telemetry.Record(ConfigurationKeys.TraceDataPipelineEnabled, false, ConfigurationOrigins.Calculated);
}
Expand All @@ -430,7 +430,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te
if (Exporter.TracesTransport == TracesTransportType.UnixDomainSocket && FrameworkDescription.Instance.IsWindows())
{
DataPipelineEnabled = false;
Log.Warning(
Log.Information(
$"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but TracesTransport is set to UnixDomainSocket which is not supported on Windows. Disabling data pipeline.");
_telemetry.Record(ConfigurationKeys.TraceDataPipelineEnabled, false, ConfigurationOrigins.Calculated);
}
Expand All @@ -440,13 +440,13 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te
DataPipelineEnabled = false;
if (isLibDatadogAvailable.Exception is not null)
{
Log.Warning(
Log.Information(
isLibDatadogAvailable.Exception,
$"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but libdatadog is not available. Disabling data pipeline.");
}
else
{
Log.Warning(
Log.Information(
$"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but libdatadog is not available. Disabling data pipeline.");
}

Expand All @@ -459,7 +459,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te
if (!string.IsNullOrEmpty(EnvironmentHelpers.GetEnvironmentVariable("DD_INJECTION_ENABLED")))
{
DataPipelineEnabled = false;
Log.Warning(
Log.Information(
$"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but SSI is enabled. Disabling data pipeline.");
_telemetry.Record(ConfigurationKeys.TraceDataPipelineEnabled, false, ConfigurationOrigins.Calculated);
}
Expand Down
5 changes: 5 additions & 0 deletions tracer/src/Datadog.Trace/FrameworkDescription.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ public bool IsWindows()
return string.Equals(OSPlatform, OSPlatformName.Windows, StringComparison.OrdinalIgnoreCase);
}

public bool IsLinux()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have been in the https://github.com/DataDog/dd-trace-dotnet/pull/7425/files PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this? Aren't we going to go Windows then everywhere? 🤔 I don't think there's much reason to not tbh

{
return string.Equals(OSPlatform, OSPlatformName.Linux, StringComparison.OrdinalIgnoreCase);
}

public override string ToString()
{
// examples:
Expand Down
Loading