Revert "Revert "[Profiler] Make `timer_create`-based CPU profiler default (#7322)"" #7444

gleocadie · 2025-08-28T07:13:21Z

Reverts #7427

dd-trace-dotnet-ci-bot · 2025-08-28T07:53:52Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (77ms)  : 73, 80
     .   : milestone, 77,

    section Baseline
    This PR (7444) - mean (70ms)  : 63, 76
     .   : milestone, 70,
    master - mean (73ms)  : 68, 79
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (987ms)  : 964, 1010
     .   : milestone, 987,
    master - mean (1,019ms)  : 1000, 1038
     .   : milestone, 1019,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (107ms)  : 106, 108
     .   : milestone, 107,
    master - mean (114ms)  : 110, 118
     .   : milestone, 114,

    section Baseline
    This PR (7444) - mean (106ms)  : 104, 108
     .   : milestone, 106,
    master - mean (113ms)  : 109, 117
     .   : milestone, 113,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (698ms)  : 678, 718
     .   : milestone, 698,
    master - mean (703ms)  : 684, 723
     .   : milestone, 703,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (94ms)  : 93, 96
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7444) - mean (94ms)  : 92, 96
     .   : milestone, 94,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (652ms)  : 634, 671
     .   : milestone, 652,
    master - mean (657ms)  : 632, 681
     .   : milestone, 657,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (94ms)  : 92, 95
     .   : milestone, 94,
    master - mean (93ms)  : 92, 94
     .   : milestone, 93,

    section Baseline
    This PR (7444) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (594ms)  : 577, 611
     .   : milestone, 594,
    master - mean (594ms)  : 584, 605
     .   : milestone, 594,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (193ms)  : 188, 198
     .   : milestone, 193,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section Baseline
    This PR (7444) - mean (190ms)  : 185, 195
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (1,091ms)  : 1058, 1124
     .   : milestone, 1091,
    master - mean (1,088ms)  : 1060, 1117
     .   : milestone, 1088,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (275ms)  : 269, 282
     .   : milestone, 275,
    master - mean (274ms)  : 265, 283
     .   : milestone, 274,

    section Baseline
    This PR (7444) - mean (274ms)  : 268, 281
     .   : milestone, 274,
    master - mean (274ms)  : 267, 281
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (886ms)  : 845, 927
     .   : milestone, 886,
    master - mean (888ms)  : 854, 923
     .   : milestone, 888,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (266ms)  : 261, 272
     .   : milestone, 266,

    section Baseline
    This PR (7444) - mean (266ms)  : 260, 271
     .   : milestone, 266,
    master - mean (265ms)  : 260, 271
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (866ms)  : 829, 902
     .   : milestone, 866,
    master - mean (867ms)  : 830, 904
     .   : milestone, 867,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7444) - mean (264ms)  : 258, 271
     .   : milestone, 264,
    master - mean (265ms)  : 259, 272
     .   : milestone, 265,

    section Baseline
    This PR (7444) - mean (265ms)  : 259, 272
     .   : milestone, 265,
    master - mean (265ms)  : 259, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (7444) - mean (777ms)  : 754, 801
     .   : milestone, 777,
    master - mean (791ms)  : 766, 816
     .   : milestone, 791,

pr-commenter · 2025-08-28T09:26:36Z

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7444 compared to master:

3 benchmarks are slower, with geometric mean 1.231
7 benchmarks have fewer allocations
6 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7444

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.02 KB	6.08 KB	66 B	1.10%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	5.64 KB	5.68 KB	38 B	0.67%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`StartStopWithChild`	net6.0	10.4μs	56.6ns	335ns	0	0	5.49 KB
master	`StartStopWithChild`	netcoreapp3.1	14μs	65.9ns	264ns	0	0	5.64 KB
master	`StartStopWithChild`	net472	22.1μs	104ns	415ns	0.903	0.113	6.02 KB
#7444	`StartStopWithChild`	net6.0	9.99μs	56ns	384ns	0	0	5.52 KB
#7444	`StartStopWithChild`	netcoreapp3.1	14.2μs	65.3ns	253ns	0	0	5.68 KB
#7444	`StartStopWithChild`	net472	21.4μs	113ns	567ns	0.873	0.218	6.08 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	932μs	120ns	464ns	2.71 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.02ms	107ns	401ns	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	1.19ms	73ns	283ns	3.31 KB
#7444	`WriteAndFlushEnrichedTraces`	net6.0	930μs	85.7ns	309ns	2.71 KB
#7444	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	1.03ms	241ns	935ns	2.7 KB
#7444	`WriteAndFlushEnrichedTraces`	net472	1.19ms	173ns	622ns	3.31 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`AllCycleSimpleBody`	net6.0	326μs	1.49μs	5.97μs	0	172.07 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	458μs	701ns	2.72μs	0	174.18 KB
master	`AllCycleSimpleBody`	net472	427μs	170ns	659ns	29.2	194.24 KB
master	`AllCycleMoreComplexBody`	net6.0	329μs	622ns	2.33μs	0	175.58 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	504μs	1.6μs	6.2μs	0	177.6 KB
master	`AllCycleMoreComplexBody`	net472	433μs	319ns	1.24μs	30.2	197.76 KB
master	`ObjectExtractorSimpleBody`	net6.0	322ns	1.84ns	12.9ns	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	394ns	2.18ns	13.3ns	0	272 B
master	`ObjectExtractorSimpleBody`	net472	303ns	0.0429ns	0.166ns	0.0443	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	6.21μs	28.4ns	114ns	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.82μs	4.23ns	16.4ns	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	6.77μs	1.4ns	5.06ns	0.602	3.8 KB
#7444	`AllCycleSimpleBody`	net6.0	320μs	262ns	979ns	0	172.08 KB
#7444	`AllCycleSimpleBody`	netcoreapp3.1	463μs	821ns	3.07μs	0	174.18 KB
#7444	`AllCycleSimpleBody`	net472	427μs	150ns	580ns	29.2	194.24 KB
#7444	`AllCycleMoreComplexBody`	net6.0	325μs	139ns	539ns	0	175.58 KB
#7444	`AllCycleMoreComplexBody`	netcoreapp3.1	484μs	1.13μs	4.38μs	0	177.6 KB
#7444	`AllCycleMoreComplexBody`	net472	435μs	110ns	425ns	30.2	197.76 KB
#7444	`ObjectExtractorSimpleBody`	net6.0	315ns	1.6ns	7.67ns	0	280 B
#7444	`ObjectExtractorSimpleBody`	netcoreapp3.1	406ns	0.365ns	1.41ns	0	272 B
#7444	`ObjectExtractorSimpleBody`	net472	298ns	0.0283ns	0.106ns	0.0436	281 B
#7444	`ObjectExtractorMoreComplexBody`	net6.0	6.39μs	3.47ns	13.4ns	0	3.78 KB
#7444	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	7.77μs	37ns	143ns	0	3.69 KB
#7444	`ObjectExtractorMoreComplexBody`	net472	6.72μs	2.75ns	10.7ns	0.572	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EncodeArgs`	net6.0	77.6μs	186ns	721ns	0	32.4 KB
master	`EncodeArgs`	netcoreapp3.1	98.3μs	136ns	508ns	0	32.4 KB
master	`EncodeArgs`	net472	113μs	8.15ns	31.6ns	5.08	32.51 KB
master	`EncodeLegacyArgs`	net6.0	144μs	38ns	147ns	0	2.15 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	193μs	53ns	205ns	0	2.14 KB
master	`EncodeLegacyArgs`	net472	262μs	25.8ns	100ns	0	2.16 KB
#7444	`EncodeArgs`	net6.0	76.7μs	46.8ns	181ns	0	32.4 KB
#7444	`EncodeArgs`	netcoreapp3.1	101μs	361ns	1.4μs	0	32.4 KB
#7444	`EncodeArgs`	net472	109μs	14.7ns	56.9ns	4.92	32.5 KB
#7444	`EncodeLegacyArgs`	net6.0	148μs	19ns	73.8ns	0	2.14 KB
#7444	`EncodeLegacyArgs`	netcoreapp3.1	196μs	66.4ns	248ns	0	2.14 KB
#7444	`EncodeLegacyArgs`	net472	277μs	40.3ns	145ns	0	2.15 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7444

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1	1.374	627,923.02	862,964.58

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`RunWafRealisticBenchmark`	net6.0	404μs	120ns	467ns	4.55 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	621μs	3.63μs	34.3μs	4.48 KB
master	`RunWafRealisticBenchmark`	net472	435μs	169ns	656ns	4.68 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	286μs	29.8ns	111ns	2.24 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	305μs	212ns	820ns	2.22 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	314μs	102ns	394ns	2.29 KB
#7444	`RunWafRealisticBenchmark`	net6.0	395μs	100ns	389ns	4.56 KB
#7444	`RunWafRealisticBenchmark`	netcoreapp3.1	795μs	13.5μs	135μs	4.48 KB
#7444	`RunWafRealisticBenchmark`	net472	434μs	46.9ns	182ns	4.66 KB
#7444	`RunWafRealisticBenchmarkWithAttack`	net6.0	286μs	46ns	178ns	2.24 KB
#7444	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	302μs	111ns	416ns	2.22 KB
#7444	`RunWafRealisticBenchmarkWithAttack`	net472	316μs	22.9ns	85.8ns	2.29 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`SendRequest`	net6.0	60.5μs	28.9ns	104ns	14.52 KB
master	`SendRequest`	netcoreapp3.1	70.1μs	240ns	866ns	17.42 KB
master	`SendRequest`	net472	0.0222ns	0.00202ns	0.00783ns	0 b
#7444	`SendRequest`	net6.0	61.3μs	287ns	1.15μs	14.52 KB
#7444	`SendRequest`	netcoreapp3.1	72μs	168ns	650ns	17.42 KB
#7444	`SendRequest`	net472	0.00557ns	0.00186ns	0.0072ns	0 b

Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7444

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0	4 B	7 B	3 B	75.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0	3 B	5 B	2 B	66.67%

Fewer allocations 🎉 in #7444

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472	73 B	0 b	-73 B	-100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472	47 B	0 b	-47 B	-100.00%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`OriginalCharSlice`	net6.0	1.93ms	2.15μs	8.03μs	0	640 KB
master	`OriginalCharSlice`	netcoreapp3.1	2.11ms	10.3μs	41.4μs	0	640 KB
master	`OriginalCharSlice`	net472	2.64ms	378ns	1.41μs	100	641.95 KB
master	`OptimizedCharSlice`	net6.0	1.36ms	369ns	1.43μs	0	4 B
master	`OptimizedCharSlice`	netcoreapp3.1	1.8ms	266ns	1.03μs	0	1 B
master	`OptimizedCharSlice`	net472	1.95ms	486ns	1.88μs	0	73 B
master	`OptimizedCharSliceWithPool`	net6.0	840μs	41.1ns	159ns	0	3 B
master	`OptimizedCharSliceWithPool`	netcoreapp3.1	800μs	50.5ns	195ns	0	0 b
master	`OptimizedCharSliceWithPool`	net472	1.16ms	134ns	520ns	0	47 B
#7444	`OriginalCharSlice`	net6.0	1.92ms	5.45μs	21.1μs	0	640.01 KB
#7444	`OriginalCharSlice`	netcoreapp3.1	2.13ms	8.06μs	31.2μs	0	640 KB
#7444	`OriginalCharSlice`	net472	2.65ms	558ns	2.01μs	100	641.95 KB
#7444	`OptimizedCharSlice`	net6.0	1.47ms	304ns	1.18μs	0	7 B
#7444	`OptimizedCharSlice`	netcoreapp3.1	1.67ms	522ns	2.02μs	0	1 B
#7444	`OptimizedCharSlice`	net472	2.02ms	1.1μs	4.27μs	0	0 b
#7444	`OptimizedCharSliceWithPool`	net6.0	805μs	46.2ns	179ns	0	5 B
#7444	`OptimizedCharSliceWithPool`	netcoreapp3.1	798μs	110ns	425ns	0	0 b
#7444	`OptimizedCharSliceWithPool`	net472	1.21ms	83.2ns	322ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7444

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	1.169	634,077.39	741,113.22	several?
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	1.160	639,694.58	742,176.67

More allocations ⚠️ in #7444

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.84 KB	42.15 KB	310 B	0.74%

Fewer allocations 🎉 in #7444

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	56.29 KB	55.67 KB	-615 B	-1.09%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	639μs	711ns	2.56μs	0	41.84 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	3.51μs	20.1μs	0	42.04 KB
master	`WriteAndFlushEnrichedTraces`	net472	863μs	2.27μs	8.48μs	8.33	56.29 KB
#7444	`WriteAndFlushEnrichedTraces`	net6.0	729μs	4.07μs	25.1μs	0	42.15 KB
#7444	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	741μs	594ns	2.3μs	0	42.12 KB
#7444	`WriteAndFlushEnrichedTraces`	net472	898μs	4.54μs	21.8μs	4.46	55.67 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.86μs	9.52ns	42.6ns	0	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	2.51μs	8.96ns	33.5ns	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.82μs	3.88ns	14.5ns	0.156	0.0142	987 B
#7444	`ExecuteNonQuery`	net6.0	1.82μs	4.58ns	17.7ns	0	0	1.02 KB
#7444	`ExecuteNonQuery`	netcoreapp3.1	2.73μs	9.09ns	32.8ns	0	0	1.02 KB
#7444	`ExecuteNonQuery`	net472	2.73μs	4.31ns	16.1ns	0.15	0.0137	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.69μs	0.738ns	2.86ns	0	1.03 KB
master	`CallElasticsearch`	netcoreapp3.1	2.27μs	10.6ns	41ns	0	1.03 KB
master	`CallElasticsearch`	net472	3.47μs	1.15ns	4.32ns	0.156	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.89μs	1.86ns	7.21ns	0	1.01 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	2.52μs	1.48ns	5.73ns	0	1.08 KB
master	`CallElasticsearchAsync`	net472	3.77μs	2.4ns	8.97ns	0.169	1.1 KB
#7444	`CallElasticsearch`	net6.0	1.72μs	0.931ns	3.6ns	0	1.03 KB
#7444	`CallElasticsearch`	netcoreapp3.1	2.18μs	10ns	38.9ns	0	1.03 KB
#7444	`CallElasticsearch`	net472	3.59μs	2.08ns	8.06ns	0.161	1.04 KB
#7444	`CallElasticsearchAsync`	net6.0	1.77μs	7.62ns	29.5ns	0	1.01 KB
#7444	`CallElasticsearchAsync`	netcoreapp3.1	2.41μs	12ns	53.6ns	0	1.08 KB
#7444	`CallElasticsearchAsync`	net472	3.75μs	2.51ns	9.72ns	0.169	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.82μs	8.22ns	31.8ns	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	2.48μs	4.8ns	18.6ns	0	952 B
master	`ExecuteAsync`	net472	2.43μs	2.8ns	10.8ns	0.134	915 B
#7444	`ExecuteAsync`	net6.0	1.85μs	4.05ns	15.7ns	0	952 B
#7444	`ExecuteAsync`	netcoreapp3.1	2.56μs	8.14ns	31.5ns	0	952 B
#7444	`ExecuteAsync`	net472	2.57μs	1.71ns	6.18ns	0.142	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	6.87μs	6.64ns	25.7ns	0	2.36 KB
master	`SendAsync`	netcoreapp3.1	8.49μs	20.5ns	79.2ns	0	2.9 KB
master	`SendAsync`	net472	12.2μs	4.68ns	17.5ns	0.486	3.18 KB
#7444	`SendAsync`	net6.0	6.92μs	24.2ns	93.9ns	0	2.36 KB
#7444	`SendAsync`	netcoreapp3.1	8.3μs	31ns	120ns	0	2.9 KB
#7444	`SendAsync`	net472	12.4μs	9.53ns	36.9ns	0.497	3.18 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7444

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	57.34 KB	65.54 KB	8.19 KB	14.29%

Fewer allocations 🎉 in #7444

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	44.43 KB	44.04 KB	-392 B	-0.88%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	259.06 KB	255.05 KB	-4.01 KB	-1.55%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1	43.86 KB	43.02 KB	-840 B	-1.92%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	276.9 KB	257.7 KB	-19.2 KB	-6.93%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	47.9μs	264ns	1.63μs	44.43 KB
master	`StringConcatBenchmark`	netcoreapp3.1	53.6μs	653ns	6.37μs	43.86 KB
master	`StringConcatBenchmark`	net472	57μs	150ns	540ns	57.34 KB
master	`StringConcatAspectBenchmark`	net6.0	474μs	1.99μs	6.89μs	276.9 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	507μs	2.51μs	11.2μs	259.06 KB
master	`StringConcatAspectBenchmark`	net472	408μs	2.1μs	10.3μs	278.53 KB
#7444	`StringConcatBenchmark`	net6.0	48μs	176ns	658ns	44.04 KB
#7444	`StringConcatBenchmark`	netcoreapp3.1	48.8μs	193ns	749ns	43.02 KB
#7444	`StringConcatBenchmark`	net472	57.4μs	180ns	649ns	65.54 KB
#7444	`StringConcatAspectBenchmark`	net6.0	461μs	1.32μs	4.59μs	257.7 KB
#7444	`StringConcatAspectBenchmark`	netcoreapp3.1	485μs	2.57μs	13.3μs	255.05 KB
#7444	`StringConcatAspectBenchmark`	net472	403μs	2.33μs	18.2μs	278.53 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.65μs	1.12ns	4.35ns	0	1.7 KB
master	`EnrichedLog`	netcoreapp3.1	3.45μs	16.6ns	70.6ns	0	1.7 KB
master	`EnrichedLog`	net472	4μs	2.33ns	9.03ns	0.26	1.64 KB
#7444	`EnrichedLog`	net6.0	2.54μs	1.38ns	5.16ns	0	1.7 KB
#7444	`EnrichedLog`	netcoreapp3.1	3.48μs	13.7ns	53.2ns	0	1.7 KB
#7444	`EnrichedLog`	net472	4.06μs	4.17ns	16.2ns	0.243	1.64 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`EnrichedLog`	net6.0	124μs	42.7ns	160ns	4.31 KB
master	`EnrichedLog`	netcoreapp3.1	128μs	58.2ns	210ns	4.31 KB
master	`EnrichedLog`	net472	167μs	79.7ns	298ns	4.52 KB
#7444	`EnrichedLog`	net6.0	123μs	118ns	459ns	4.31 KB
#7444	`EnrichedLog`	netcoreapp3.1	127μs	77.5ns	279ns	4.31 KB
#7444	`EnrichedLog`	net472	169μs	110ns	398ns	4.52 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.8μs	18.7ns	70ns	0	2.26 KB
master	`EnrichedLog`	netcoreapp3.1	6.48μs	27.1ns	105ns	0	2.26 KB
master	`EnrichedLog`	net472	7.56μs	7.68ns	29.8ns	0.301	2.08 KB
#7444	`EnrichedLog`	net6.0	4.85μs	14.4ns	55.7ns	0	2.26 KB
#7444	`EnrichedLog`	netcoreapp3.1	6.71μs	20.3ns	78.7ns	0	2.26 KB
#7444	`EnrichedLog`	net472	7.49μs	8.96ns	34.7ns	0.297	2.08 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	2.03μs	9.52ns	39.2ns	0	1.2 KB
master	`SendReceive`	netcoreapp3.1	2.5μs	11.6ns	47.8ns	0	1.2 KB
master	`SendReceive`	net472	3.18μs	0.991ns	3.43ns	0.189	1.2 KB
#7444	`SendReceive`	net6.0	2.05μs	8.07ns	31.2ns	0	1.2 KB
#7444	`SendReceive`	netcoreapp3.1	2.61μs	12.5ns	51.5ns	0	1.2 KB
#7444	`SendReceive`	net472	3.13μs	4.16ns	16.1ns	0.187	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	4.05μs	3.08ns	11.9ns	0	1.58 KB
master	`EnrichedLog`	netcoreapp3.1	5.66μs	16.1ns	62.3ns	0	1.63 KB
master	`EnrichedLog`	net472	6.63μs	7.99ns	29.9ns	0.299	2.03 KB
#7444	`EnrichedLog`	net6.0	4.11μs	3.29ns	12.3ns	0	1.58 KB
#7444	`EnrichedLog`	netcoreapp3.1	5.68μs	15.7ns	60.9ns	0	1.63 KB
#7444	`EnrichedLog`	net472	6.54μs	5.77ns	22.4ns	0.294	2.03 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	738ns	1.37ns	5.13ns	0	576 B
master	`StartFinishSpan`	netcoreapp3.1	927ns	3.27ns	12.7ns	0	576 B
master	`StartFinishSpan`	net472	902ns	0.0372ns	0.129ns	0.0901	578 B
master	`StartFinishScope`	net6.0	891ns	0.33ns	1.19ns	0	696 B
master	`StartFinishScope`	netcoreapp3.1	1.13μs	6.12ns	33ns	0	696 B
master	`StartFinishScope`	net472	1.1μs	0.385ns	1.39ns	0.0994	658 B
#7444	`StartFinishSpan`	net6.0	729ns	4.07ns	25.1ns	0	576 B
#7444	`StartFinishSpan`	netcoreapp3.1	938ns	4.95ns	28ns	0	576 B
#7444	`StartFinishSpan`	net472	898ns	0.0367ns	0.132ns	0.0901	578 B
#7444	`StartFinishScope`	net6.0	889ns	4.35ns	17.9ns	0	696 B
#7444	`StartFinishScope`	netcoreapp3.1	1.1μs	5.55ns	26ns	0	696 B
#7444	`StartFinishScope`	net472	1.09μs	0.229ns	0.886ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	1.03μs	5.34ns	25ns	0	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.31μs	6.59ns	30.9ns	0	696 B
master	`RunOnMethodBegin`	net472	1.38μs	0.562ns	2.18ns	0.104	658 B
#7444	`RunOnMethodBegin`	net6.0	1.04μs	5.42ns	28.2ns	0	696 B
#7444	`RunOnMethodBegin`	netcoreapp3.1	1.43μs	5.45ns	21.1ns	0	696 B
#7444	`RunOnMethodBegin`	net472	1.36μs	1.32ns	5.11ns	0.103	658 B

datadog-official · 2025-08-28T13:48:25Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 941eac3 | Docs | Was this helpful? Give us feedback!}

…ault (#7…" This reverts commit f33b932.

…ng destroyed

github-actions bot added the area:profiler Issues related to the continous-profiler label Aug 28, 2025

gleocadie and others added 6 commits September 2, 2025 16:43

Revert "Revert "[Profiler] Make timer_create-based CPU profiler def…

dfb9644

…ault (#7…" This reverts commit f33b932.

disable crash report at the CLR level to get a coredump

d619c5c

use std::atomic and std::shared_ptr

6148901

Do not clean up the cpuprofiler

6cb2d40

Debugging...

0d1f8a2

Try generating coredump not using createdump

fa842e6

gleocadie force-pushed the revert-7427-andrew/ci/try-revert-timer-create branch 2 times, most recently from 50da4ed to 1eab03e Compare September 3, 2025 07:51

Try letting coredump be generated by the kernel

e751b70

gleocadie force-pushed the revert-7427-andrew/ci/try-revert-timer-create branch from 1eab03e to e751b70 Compare September 3, 2025 08:39

Try another thing: do not call into the profiler when a thread is bei…

afeae39

…ng destroyed

gleocadie force-pushed the revert-7427-andrew/ci/try-revert-timer-create branch 2 times, most recently from 52cb29f to 13e306d Compare September 5, 2025 08:02

Try something: move the signal handler detection earlier

941eac3

gleocadie force-pushed the revert-7427-andrew/ci/try-revert-timer-create branch from 13e306d to 941eac3 Compare September 5, 2025 09:51

Revert "Revert "[Profiler] Make timer_create-based CPU profiler default (#7322)"" #7444

Are you sure you want to change the base?

Revert "Revert "[Profiler] Make timer_create-based CPU profiler default (#7322)"" #7444

Uh oh!

Conversation

gleocadie commented Aug 28, 2025

Uh oh!

dd-trace-dotnet-ci-bot bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

pr-commenter bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmark details

More allocations ⚠️ in #7444

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #7444

Raw results

Raw results

More allocations ⚠️ in #7444

Fewer allocations 🎉 in #7444

Raw results

Slower ⚠️ in #7444

More allocations ⚠️ in #7444

Fewer allocations 🎉 in #7444

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #7444

Fewer allocations 🎉 in #7444

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

datadog-official bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Revert "Revert "[Profiler] Make `timer_create`-based CPU profiler default (#7322)"" #7444

Revert "Revert "[Profiler] Make `timer_create`-based CPU profiler default (#7322)"" #7444

dd-trace-dotnet-ci-bot bot commented Aug 28, 2025 •

edited

Loading

pr-commenter bot commented Aug 28, 2025 •

edited

Loading

datadog-official bot commented Aug 28, 2025 •

edited

Loading