Skip to content

Split BuildAndRunProfilerCpuLimitTests #7650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Split BuildAndRunProfilerCpuLimitTests #7650

wants to merge 5 commits into from
+44 −7

Conversation

NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Oct 14, 2025 •
edited
Loading

Summary of changes

This PR splits the target BuildAndRunProfilerCpuLimitTests into BuildProfilerCpuLimitTests and RunProfilerCpuLimitTests. We want to retry the build of the test projects to avoid flaky errors but not when we run the tests to avoid timeouts in case of a failing test.

While target BuildAndRunProfilerCpuLimitTests is no longer used in the pipeline, it has been left for local testing.

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 14, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 14, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (75ms)  : 73, 77
     .   : milestone, 75,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7650) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (1,076ms)  : 996, 1155
     .   : milestone, 1076,
    master - mean (1,046ms)  : 1008, 1084
     .   : milestone, 1046,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (110ms)  : 108, 112
     .   : milestone, 110,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7650) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (105ms)  : 103, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (757ms)  : 733, 780
     .   : milestone, 757,
    master - mean (744ms)  : 719, 769
     .   : milestone, 744,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (98ms)  : 96, 100
     .   : milestone, 98,
    master - mean (101ms)  : 100, 102
     .   : milestone, 101,

    section Baseline
    This PR (7650) - mean (97ms)  : 95, 99
     .   : milestone, 97,
    master - mean (100ms)  : 97, 102
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (716ms)  : 693, 740
     .   : milestone, 716,
    master - mean (776ms)  : 729, 824
     .   : milestone, 776,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (97ms)  : 95, 100
     .   : milestone, 97,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section Baseline
    This PR (7650) - mean (95ms)  : 93, 98
     .   : milestone, 95,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (673ms)  : 654, 692
     .   : milestone, 673,
    master - mean (661ms)  : 648, 674
     .   : milestone, 661,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (199ms)  : 195, 202
     .   : milestone, 199,
    master - mean (195ms)  : 193, 198
     .   : milestone, 195,

    section Baseline
    This PR (7650) - mean (195ms)  : 191, 200
     .   : milestone, 195,
    master - mean (192ms)  : 188, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (1,175ms)  : 1120, 1230
     .   : milestone, 1175,
    master - mean (1,163ms)  : 1108, 1218
     .   : milestone, 1163,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (280ms)  : 275, 285
     .   : milestone, 280,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section Baseline
    This PR (7650) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (277ms)  : 269, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (957ms)  : 915, 999
     .   : milestone, 957,
    master - mean (946ms)  : 909, 984
     .   : milestone, 946,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (271ms)  : 266, 277
     .   : milestone, 271,
    master - mean (280ms)  : 275, 285
     .   : milestone, 280,

    section Baseline
    This PR (7650) - mean (271ms)  : 266, 275
     .   : milestone, 271,
    master - mean (279ms)  : 275, 283
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (938ms)  : 889, 987
     .   : milestone, 938,
    master - mean (996ms)  : 953, 1040
     .   : milestone, 996,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7650) - mean (271ms)  : 267, 276
     .   : milestone, 271,
    master - mean (268ms)  : 263, 272
     .   : milestone, 268,

    section Baseline
    This PR (7650) - mean (271ms)  : 267, 276
     .   : milestone, 271,
    master - mean (267ms)  : 264, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (7650) - mean (857ms)  : 834, 880
     .   : milestone, 857,
    master - mean (857ms)  : 835, 880
     .   : milestone, 857,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7650 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.244
  • 3 benchmarks are slower, with geometric mean 1.146
  • 10 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6 KB 6.09 KB 94 B 1.57%

Fewer allocations 🎉 in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.74 KB 5.7 KB -44 B -0.77%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.9μs 58.4ns 330ns 0 0 0 5.53 KB
master StartStopWithChild netcoreapp3.1 14.8μs 71.5ns 286ns 0 0 0 5.74 KB
master StartStopWithChild net472 21.9μs 109ns 511ns 0.958 0.426 0.106 6 KB
#7650 StartStopWithChild net6.0 10.4μs 57.5ns 355ns 0 0 0 5.52 KB
#7650 StartStopWithChild netcoreapp3.1 15μs 64.6ns 250ns 0 0 0 5.7 KB
#7650 StartStopWithChild net472 22.9μs 121ns 626ns 1.05 0.315 0.105 6.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.35 KB 46 B 1.39%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 943μs 144ns 558ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 45.9ns 172ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 82.2ns 318ns 0 0 0 3.31 KB
#7650 WriteAndFlushEnrichedTraces net6.0 934μs 210ns 757ns 0 0 0 2.71 KB
#7650 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 93.8ns 351ns 0 0 0 2.7 KB
#7650 WriteAndFlushEnrichedTraces net472 1.18ms 100ns 374ns 0 0 0 3.35 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 355μs 1.84μs 8.63μs 0 0 0 180.01 KB
master AllCycleSimpleBody netcoreapp3.1 523μs 1.68μs 7.7μs 0 0 0 185.8 KB
master AllCycleSimpleBody net472 469μs 157ns 607ns 32.4 0 0 206.3 KB
master AllCycleMoreComplexBody net6.0 367μs 1.23μs 4.78μs 0 0 0 183.53 KB
master AllCycleMoreComplexBody netcoreapp3.1 552μs 636ns 2.46μs 0 0 0 189.23 KB
master AllCycleMoreComplexBody net472 480μs 74.7ns 269ns 31.2 0 0 209.83 KB
master ObjectExtractorSimpleBody net6.0 330ns 1.62ns 7.08ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 1.97ns 8.57ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 296ns 0.0313ns 0.117ns 0.0432 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.24μs 33.6ns 121ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.82μs 39.5ns 185ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.68μs 3.02ns 11.7ns 0.6 0 0 3.8 KB
#7650 AllCycleSimpleBody net6.0 354μs 947ns 3.67μs 0 0 0 180.01 KB
#7650 AllCycleSimpleBody netcoreapp3.1 533μs 1.95μs 7.29μs 0 0 0 185.8 KB
#7650 AllCycleSimpleBody net472 472μs 119ns 444ns 32.4 0 0 206.3 KB
#7650 AllCycleMoreComplexBody net6.0 366μs 136ns 508ns 0 0 0 183.53 KB
#7650 AllCycleMoreComplexBody netcoreapp3.1 536μs 1.86μs 7.19μs 0 0 0 189.23 KB
#7650 AllCycleMoreComplexBody net472 481μs 103ns 401ns 31.2 0 0 209.83 KB
#7650 ObjectExtractorSimpleBody net6.0 318ns 1.65ns 7.75ns 0 0 0 280 B
#7650 ObjectExtractorSimpleBody netcoreapp3.1 398ns 2.18ns 12.5ns 0 0 0 272 B
#7650 ObjectExtractorSimpleBody net472 306ns 0.0599ns 0.232ns 0.0446 0 0 281 B
#7650 ObjectExtractorMoreComplexBody net6.0 6.25μs 32.4ns 162ns 0 0 0 3.78 KB
#7650 ObjectExtractorMoreComplexBody netcoreapp3.1 7.87μs 25.8ns 96.4ns 0 0 0 3.69 KB
#7650 ObjectExtractorMoreComplexBody net472 7.15μs 1.72ns 6.42ns 0.57 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.6μs 209ns 808ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.1μs 327ns 1.27μs 0 0 0 32.4 KB
master EncodeArgs net472 109μs 14.2ns 55.1ns 4.93 0 0 32.5 KB
master EncodeLegacyArgs net6.0 146μs 36.9ns 138ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 196μs 172ns 666ns 0 0 0 2.15 KB
master EncodeLegacyArgs net472 262μs 23.9ns 89.4ns 0 0 0 2.16 KB
#7650 EncodeArgs net6.0 77.6μs 151ns 566ns 0 0 0 32.4 KB
#7650 EncodeArgs netcoreapp3.1 96.3μs 271ns 1.05μs 0 0 0 32.4 KB
#7650 EncodeArgs net472 109μs 48.6ns 182ns 4.92 0 0 32.5 KB
#7650 EncodeLegacyArgs net6.0 146μs 7.33ns 25.4ns 0 0 0 2.15 KB
#7650 EncodeLegacyArgs netcoreapp3.1 197μs 83.3ns 312ns 0 0 0 2.14 KB
#7650 EncodeLegacyArgs net472 264μs 28.6ns 111ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 2.3 KB 2.29 KB -19 B -0.82%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 405μs 45.1ns 175ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 845μs 7.21μs 71.4μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 429μs 45.4ns 176ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 288μs 34.7ns 125ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 301μs 45.7ns 177ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 312μs 35.2ns 136ns 0 0 0 2.3 KB
#7650 RunWafRealisticBenchmark net6.0 402μs 144ns 521ns 0 0 0 4.55 KB
#7650 RunWafRealisticBenchmark netcoreapp3.1 854μs 5.41μs 53.6μs 0 0 0 4.48 KB
#7650 RunWafRealisticBenchmark net472 427μs 72ns 279ns 0 0 0 4.66 KB
#7650 RunWafRealisticBenchmarkWithAttack net6.0 284μs 67.1ns 251ns 0 0 0 2.24 KB
#7650 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 303μs 311ns 1.2μs 0 0 0 2.22 KB
#7650 RunWafRealisticBenchmarkWithAttack net472 316μs 81ns 314ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 97.1ns 388ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.3μs 72.5ns 271ns 0 0 0 17.42 KB
master SendRequest net472 0.000824ns 0.000615ns 0.00238ns 0 0 0 0 b
#7650 SendRequest net6.0 61.6μs 54.7ns 212ns 0 0 0 14.52 KB
#7650 SendRequest netcoreapp3.1 72.4μs 338ns 1.65μs 0 0 0 17.42 KB
#7650 SendRequest net472 0.00304ns 0.00159ns 0.00615ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7650

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 1.131 1,337,186.81 1,511,755.21

More allocations ⚠️ in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 3 B 5 B 2 B 66.67%

Fewer allocations 🎉 in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1 B 0 b -1 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.94ms 462ns 1.67μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.12ms 919ns 3.18μs 0 0 0 640 KB
master OriginalCharSlice net472 2.66ms 403ns 1.51μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.34ms 469ns 1.82μs 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.68ms 794ns 2.97μs 0 0 0 1 B
master OptimizedCharSlice net472 1.96ms 303ns 1.17μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 799μs 66.6ns 258ns 0 0 0 3 B
master OptimizedCharSliceWithPool netcoreapp3.1 828μs 94.8ns 367ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.15ms 98.4ns 381ns 0 0 0 47 B
#7650 OriginalCharSlice net6.0 1.89ms 4.74μs 18.3μs 0 0 0 640.01 KB
#7650 OriginalCharSlice netcoreapp3.1 2.23ms 10.5μs 40.6μs 0 0 0 640 KB
#7650 OriginalCharSlice net472 2.66ms 453ns 1.69μs 100 0 0 641.95 KB
#7650 OptimizedCharSlice net6.0 1.51ms 361ns 1.4μs 0 0 0 4 B
#7650 OptimizedCharSlice netcoreapp3.1 1.73ms 352ns 1.36μs 0 0 0 1 B
#7650 OptimizedCharSlice net472 1.97ms 249ns 931ns 0 0 0 73 B
#7650 OptimizedCharSliceWithPool net6.0 800μs 36.1ns 140ns 0 0 0 5 B
#7650 OptimizedCharSliceWithPool netcoreapp3.1 871μs 44ns 165ns 0 0 0 0 b
#7650 OptimizedCharSliceWithPool net472 1.15ms 106ns 410ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7650

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.164 876,889.79 1,020,684.38

More allocations ⚠️ in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.86 KB 43.06 KB 1.2 KB 2.85%

Fewer allocations 🎉 in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.63 KB 56.15 KB -481 B -0.85%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.04 KB 41.63 KB -411 B -0.98%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 671μs 2.44μs 9.44μs 0 0 0 42.04 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 726μs 1.26μs 4.54μs 0 0 0 41.86 KB
master WriteAndFlushEnrichedTraces net472 878μs 3.99μs 14.9μs 8.33 0 0 56.63 KB
#7650 WriteAndFlushEnrichedTraces net6.0 665μs 2.31μs 8.33μs 0 0 0 41.63 KB
#7650 WriteAndFlushEnrichedTraces netcoreapp3.1 752μs 3.7μs 15.2μs 0 0 0 43.06 KB
#7650 WriteAndFlushEnrichedTraces net472 1.02ms 5.19μs 23.8μs 4.46 0 0 56.15 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 1.41ns 5.47ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.54μs 5.69ns 22ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.79μs 3.37ns 12.2ns 0.153 0.0139 0 987 B
#7650 ExecuteNonQuery net6.0 1.87μs 5.43ns 21ns 0 0 0 1.02 KB
#7650 ExecuteNonQuery netcoreapp3.1 2.57μs 6.18ns 23.9ns 0 0 0 1.02 KB
#7650 ExecuteNonQuery net472 2.86μs 3.41ns 13.2ns 0.143 0.0143 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 0.913ns 3.42ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.7ns 53.5ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.63μs 5.43ns 21ns 0.163 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.97μs 9.43ns 40ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.42μs 9.88ns 38.3ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.89μs 4.99ns 18.7ns 0.155 0 0 1.1 KB
#7650 CallElasticsearch net6.0 1.86μs 8.16ns 31.6ns 0 0 0 1.03 KB
#7650 CallElasticsearch netcoreapp3.1 2.37μs 12ns 53.8ns 0 0 0 1.03 KB
#7650 CallElasticsearch net472 3.64μs 2.08ns 8.05ns 0.163 0 0 1.04 KB
#7650 CallElasticsearchAsync net6.0 1.92μs 7.2ns 27.9ns 0 0 0 1.01 KB
#7650 CallElasticsearchAsync netcoreapp3.1 2.41μs 8.82ns 34.2ns 0 0 0 1.08 KB
#7650 CallElasticsearchAsync net472 3.87μs 3.78ns 14.6ns 0.174 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.92μs 8.88ns 35.5ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.35μs 3.63ns 13.6ns 0 0 0 952 B
master ExecuteAsync net472 2.6μs 3.82ns 14.8ns 0.142 0 0 915 B
#7650 ExecuteAsync net6.0 1.89μs 1.82ns 6.57ns 0 0 0 952 B
#7650 ExecuteAsync netcoreapp3.1 2.4μs 7.11ns 27.6ns 0 0 0 952 B
#7650 ExecuteAsync net472 2.59μs 2.31ns 8.66ns 0.143 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.87μs 6.27ns 24.3ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.5μs 19.2ns 74.3ns 0 0 0 2.9 KB
master SendAsync net472 12.7μs 10ns 37.5ns 0.444 0 0 3.18 KB
#7650 SendAsync net6.0 7μs 10ns 38.9ns 0 0 0 2.36 KB
#7650 SendAsync netcoreapp3.1 8.61μs 7.83ns 30.3ns 0 0 0 2.9 KB
#7650 SendAsync net472 12.5μs 8.36ns 30.1ns 0.442 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7650

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.244 542,200.00 435,700.00 several?

More allocations ⚠️ in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 286.72 KB 8.19 KB 2.94%

Fewer allocations 🎉 in #7650

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.93 KB 257.16 KB -2.77 KB -1.06%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 43.28 KB 42.74 KB -544 B -1.26%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 279.94 KB 273.82 KB -6.11 KB -2.18%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 46.09 KB 44.81 KB -1.28 KB -2.78%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 45μs 244ns 1.86μs 0 0 0 46.09 KB
master StringConcatBenchmark netcoreapp3.1 51μs 271ns 1.84μs 0 0 0 43.28 KB
master StringConcatBenchmark net472 56.2μs 239ns 893ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 462μs 1.42μs 4.92μs 0 0 0 259.93 KB
master StringConcatAspectBenchmark netcoreapp3.1 542μs 1.79μs 6.68μs 0 0 0 279.94 KB
master StringConcatAspectBenchmark net472 406μs 2.33μs 17.8μs 0 0 0 278.53 KB
#7650 StringConcatBenchmark net6.0 46μs 641ns 6.37μs 0 0 0 44.81 KB
#7650 StringConcatBenchmark netcoreapp3.1 46.8μs 240ns 1.53μs 0 0 0 42.74 KB
#7650 StringConcatBenchmark net472 57μs 285ns 1.18μs 0 0 0 57.34 KB
#7650 StringConcatAspectBenchmark net6.0 452μs 1.51μs 5.22μs 0 0 0 257.16 KB
#7650 StringConcatAspectBenchmark netcoreapp3.1 474μs 7.02μs 69.5μs 0 0 0 273.82 KB
#7650 StringConcatAspectBenchmark net472 401μs 1.8μs 6.99μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 7.61ns 28.5ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.61μs 4.24ns 16.4ns 0 0 0 1.7 KB
master EnrichedLog net472 3.75μs 3.22ns 12.5ns 0.243 0 0 1.64 KB
#7650 EnrichedLog net6.0 2.68μs 3.98ns 15.4ns 0 0 0 1.7 KB
#7650 EnrichedLog netcoreapp3.1 3.69μs 13.5ns 52.4ns 0 0 0 1.7 KB
#7650 EnrichedLog net472 3.83μs 2.73ns 10.6ns 0.249 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 31.2ns 117ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 133ns 480ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 47.7ns 178ns 0 0 0 4.52 KB
#7650 EnrichedLog net6.0 123μs 47.5ns 171ns 0 0 0 4.31 KB
#7650 EnrichedLog netcoreapp3.1 126μs 80.7ns 291ns 0 0 0 4.31 KB
#7650 EnrichedLog net472 167μs 77.5ns 279ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 24.6ns 116ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.74μs 20ns 77.5ns 0 0 0 2.26 KB
master EnrichedLog net472 7.35μs 7.72ns 29.9ns 0.294 0 0 2.08 KB
#7650 EnrichedLog net6.0 4.85μs 17.2ns 66.5ns 0 0 0 2.26 KB
#7650 EnrichedLog netcoreapp3.1 6.78μs 3.7ns 14.3ns 0 0 0 2.26 KB
#7650 EnrichedLog net472 7.56μs 7.62ns 29.5ns 0.305 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.96μs 10.5ns 57.8ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.63μs 12ns 45ns 0 0 0 1.2 KB
master SendReceive net472 3.17μs 2.85ns 11ns 0.189 0 0 1.2 KB
#7650 SendReceive net6.0 1.96μs 10.7ns 60.7ns 0 0 0 1.2 KB
#7650 SendReceive netcoreapp3.1 2.7μs 11.8ns 44ns 0 0 0 1.2 KB
#7650 SendReceive net472 3.2μs 6ns 23.2ns 0.176 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.27μs 14.5ns 56.2ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.72μs 7.47ns 28ns 0 0 0 1.63 KB
master EnrichedLog net472 6.44μs 3.42ns 13.2ns 0.291 0 0 2.03 KB
#7650 EnrichedLog net6.0 4.16μs 17.7ns 68.5ns 0 0 0 1.58 KB
#7650 EnrichedLog netcoreapp3.1 5.91μs 6.02ns 23.3ns 0 0 0 1.63 KB
#7650 EnrichedLog net472 6.46μs 10ns 38.8ns 0.321 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 767ns 0.551ns 2.13ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 964ns 4.96ns 23.3ns 0 0 0 576 B
master StartFinishSpan net472 905ns 0.375ns 1.4ns 0.0905 0 0 578 B
master StartFinishScope net6.0 909ns 4.68ns 23ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.18μs 5.81ns 23.2ns 0 0 0 696 B
master StartFinishScope net472 1.13μs 0.0482ns 0.174ns 0.102 0 0 658 B
#7650 StartFinishSpan net6.0 755ns 3.38ns 13.1ns 0 0 0 576 B
#7650 StartFinishSpan netcoreapp3.1 959ns 4.5ns 18ns 0 0 0 576 B
#7650 StartFinishSpan net472 946ns 0.42ns 1.57ns 0.0916 0 0 578 B
#7650 StartFinishScope net6.0 924ns 4.88ns 25.3ns 0 0 0 696 B
#7650 StartFinishScope netcoreapp3.1 1.23μs 5.72ns 22.1ns 0 0 0 696 B
#7650 StartFinishScope net472 1.09μs 0.568ns 2.2ns 0.1 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7650

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 1.145 1,406.03 1,609.38

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 5.67ns 34.9ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.4μs 6.93ns 31ns 0 0 0 696 B
master RunOnMethodBegin net472 1.41μs 0.647ns 2.42ns 0.101 0 0 658 B
#7650 RunOnMethodBegin net6.0 1.04μs 0.345ns 1.25ns 0 0 0 696 B
#7650 RunOnMethodBegin netcoreapp3.1 1.43μs 3.59ns 13.9ns 0 0 0 696 B
#7650 RunOnMethodBegin net472 1.6μs 5.91ns 22.9ns 0.0973 0 0 658 B

NachoEchevarria
NachoEchevarria commented Oct 14, 2025
View reviewed changes
tracer/test/Datadog.Trace.Tests/ContinuousProfiler/ProfilerAvailabilityHelperTests.cs
public void IsContinuousProfilerAvailable_OnUnsupportedPlatforms_ReturnsFalse()
{
// Skip on platforms that it's available
// Skip on platforms that it's available.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy change to launch the profiler tests in this PR

@NachoEchevarria NachoEchevarria changed the title Split targets Split BuildAndRunProfilerCpuLimitTests Oct 14, 2025
@NachoEchevarria NachoEchevarria marked this pull request as ready for review October 14, 2025 13:50
@NachoEchevarria NachoEchevarria requested review from a team as code owners October 14, 2025 13:50
@NachoEchevarria NachoEchevarria marked this pull request as draft October 14, 2025 13:54
andrewlock
andrewlock reviewed Oct 14, 2025
View reviewed changes
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NachoEchevarria @andrewlock