Skip to content

Conversation

NachoEchevarria
Copy link
Collaborator

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@NachoEchevarria NachoEchevarria changed the title Update to RC2 Update to .NET RC2 Oct 15, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 17, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (72ms)  : 70, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7659) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 67, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (1,060ms)  : 987, 1133
     .   : milestone, 1060,
    master - mean (1,052ms)  : 986, 1118
     .   : milestone, 1052,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (105ms)  : 104, 107
     .   : milestone, 105,

    section Baseline
    This PR (7659) - mean (106ms)  : 103, 108
     .   : milestone, 106,
    master - mean (105ms)  : 103, 107
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (746ms)  : 724, 767
     .   : milestone, 746,
    master - mean (742ms)  : 722, 762
     .   : milestone, 742,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7659) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (94ms)  : 92, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (699ms)  : 676, 721
     .   : milestone, 699,
    master - mean (721ms)  : 660, 781
     .   : milestone, 721,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (92ms)  : 91, 94
     .   : milestone, 92,

    section Baseline
    This PR (7659) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (655ms)  : 644, 666
     .   : milestone, 655,
    master - mean (663ms)  : 649, 677
     .   : milestone, 663,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (197ms)  : 193, 201
     .   : milestone, 197,
    master - mean (197ms)  : 193, 201
     .   : milestone, 197,

    section Baseline
    This PR (7659) - mean (193ms)  : 190, 196
     .   : milestone, 193,
    master - mean (194ms)  : 189, 199
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (1,163ms)  : 1110, 1215
     .   : milestone, 1163,
    master - mean (1,169ms)  : 1115, 1224
     .   : milestone, 1169,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (279ms)  : 273, 284
     .   : milestone, 279,

    section Baseline
    This PR (7659) - mean (277ms)  : 270, 285
     .   : milestone, 277,
    master - mean (277ms)  : 271, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (946ms)  : 907, 985
     .   : milestone, 946,
    master - mean (947ms)  : 896, 998
     .   : milestone, 947,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (271ms)  : 266, 275
     .   : milestone, 271,
    master - mean (271ms)  : 266, 275
     .   : milestone, 271,

    section Baseline
    This PR (7659) - mean (270ms)  : 264, 277
     .   : milestone, 270,
    master - mean (271ms)  : 265, 277
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (924ms)  : 876, 972
     .   : milestone, 924,
    master - mean (932ms)  : 884, 979
     .   : milestone, 932,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7659) - mean (271ms)  : 266, 276
     .   : milestone, 271,
    master - mean (270ms)  : 265, 276
     .   : milestone, 270,

    section Baseline
    This PR (7659) - mean (269ms)  : 265, 274
     .   : milestone, 269,
    master - mean (270ms)  : 265, 276
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7659) - mean (849ms)  : 830, 868
     .   : milestone, 849,
    master - mean (860ms)  : 840, 881
     .   : milestone, 860,

Loading

<PackageReference Include="System.Management" Version="5.0.0" />
</ItemGroup>

<ItemGroup>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error (active) CS0103 The name 'RegistryHive' does not exist in the current context Datadog.Trace.Tools.Runner (net5.0), Datadog.Trace.Tools.Runner (netcoreapp2.1), Datadog.Trace.Tools.Runner (netcoreapp2.2), Datadog.Trace.Tools.Runner (netcoreapp3.0), Datadog.Trace.Tools.Runner (netcoreapp3.1)

<ProjectReference Include="..\..\..\..\src\Datadog.Trace.OpenTracing\Datadog.Trace.OpenTracing.csproj" />
<PackageReference Include="FluentAssertions" Version="6.4.0" />
</ItemGroup>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ERR] CompileSamples: C:\Commonfolder\shared\repos\dd-trace-5\tracer\test\test-applications\integrations\Samples.OpenTracing\Program.cs(107,9): error CS0012: The type 'HttpResponseMessage' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

</ItemGroup>


<ItemGroup Condition="$(TargetFramework.StartsWith('net4'))">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error CS0234: The type or namespace name 'Http' does not exist in the namespace

<!-- override to remove not supported platforms -->
<TargetFrameworks>netcoreapp3.1;net5.0;net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>

<!-- Only run older version of HotChocolate for net5.0 and netcoreapp3.1 (support dropped in version 13.*.*) -->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET RC2 made assembly version checks stricter for older targets like netcoreapp3.1. RC1 allowed a NuGet package (HotChocolate 12.x, built against Microsoft.Extensions.DependencyInjection.Abstractions 3.1.4.0) to override the framework’s built-in 3.1.0.0 assembly, so it compiled. RC2 now enforces the framework reference from Microsoft.AspNetCore.App, so any dependency built for 3.1.4.0 fails. Using HotChocolate 11.0.9, which was compiled against 3.1.0.0 like the framework, restores version alignment and lets netcoreapp3.1 build successfully.

Copy link

datadog-official bot commented Oct 17, 2025

⚠️ Tests

⚠️ Warnings

🧪 21 Tests failed

DirectlyShipsLogs from Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests (Datadog)
Expected exit code: 0, actual exit code: 255.
DirectlyShipsLogs from Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests (Datadog)
Expected exit code: 0, actual exit code: 255.
DirectlyShipsLogs from Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests (Datadog)
Expected exit code: 0, actual exit code: 255.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 99b9a69 | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant