feat(ddtrace/tracer): introduce ExtractCtx to support propagated context #3866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2025-08-13 09:29:15 Comparing candidate commit 831161b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
mtoffl01
reviewed
Aug 12, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return contextWithSpanContext(ctx, sctx), nil |
There was a problem hiding this comment.
If Extract returns a nil sctx, then we set nil on the context at the key. Is that ok?
There was a problem hiding this comment.
Uhm, you are totally right, and I think it's not ok. We should avoid setting any nil value.
mtoffl01
reviewed
Aug 12, 2025
ddtrace/tracer/context.go
Outdated
|
|
||
| // contextWithSpanContext returns a copy of the given context which includes the span context sctx. | ||
| func contextWithSpanContext(ctx context.Context, sctx *SpanContext) context.Context { | ||
| return orchestrion.CtxWithValue(ctx, internal.ActiveSpanKey, sctx) |
There was a problem hiding this comment.
Should this be internal.ActiveSpanContextKey instead of internal.ActiveSpanKey
mtoffl01
reviewed
Aug 12, 2025
darccio
force-pushed
the
dario.castane/langplat-727/extract-ctx
branch
from
d609de6 to
831161b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
ExtractCtxto simplify the creation of child spans from propagated contexts.Some notes:
ExtractCtxto reduce the increase on public API.ChildOfinternally, which expects aSpanContext, so instead of reusing the existingActiveSpanKeywe create a new one forActiveSpanContextKey(which it doesn't have precedence overActiveSpanKeyvalue).Motivation
Fixes #3793
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!