fix(contrib/gorm.io): allow resource name to be overridden by custom tags #3909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darccio
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
LGTM, leaving to @rarguelloF the definitive approval. I wonder if this should be applied to other contribs with this behaviour.
will-bem
force-pushed
the
contrib-gorm-resource-name
branch
2 times, most recently
from
f211614 to
a1a4af1
Compare
will-bem
force-pushed
the
contrib-gorm-resource-name
branch
from
a1a4af1 to
4102032
Compare
|
@rarguelloF Would you mind if I asked for a review of this please? I would love to be able to override the resource name! Thanks for your consideration! |
rarguelloF
requested changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using package github.com/DataDog/dd-trace-go/contrib/gorm.io/gorm.v1/v2, I want to override the resource name (because the SQL is long and unwieldy). Alas, I cannot do this with
gormtrace.WithCustomTag(ext.ResourceName, ...because thespan.SetTag(ext.ResourceName, db.Statement.SQL.String())call is done after processing custom tags. Thus, I propose moving the custom tag processing to below where the default resource name is set.Thank you for your consideration!