Skip to content

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Aug 25, 2025

What does this PR do?

This PR implements an HAProxy SPOE messages handler that can be used to create full featured AAP HAProxy agent (coming part of #3913).

This PR uses the message_processor package implemented from #3860 and implements its own HAProxy message processor.

This implementation use the library github.com/negasus/haproxy-spoe-go for the communication between haproxy and the agent (implementing the SPOP).

Motivation

New proxy integration supported for AAP: HAProxy

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@e-n-0 e-n-0 changed the base branch from main to flavien/envoy/refactor-separation August 25, 2025 12:45
@e-n-0 e-n-0 force-pushed the flavien/envoy/refactor-separation branch from 3518fb7 to 049d56e Compare August 25, 2025 12:46
@pr-commenter
Copy link

pr-commenter bot commented Aug 25, 2025

Benchmarks

Benchmark execution time: 2025-09-24 09:45:47

Comparing candidate commit 39c6213 in PR branch flavien/contrib/haproxy with baseline commit a7d75a7 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagStringer-24

  • 🟥 execution_time [+2.471ns; +8.529ns] or [+2.026%; +6.993%]

@e-n-0 e-n-0 force-pushed the flavien/contrib/haproxy branch from 1c79257 to 122b92f Compare August 25, 2025 13:16
@e-n-0 e-n-0 force-pushed the flavien/envoy/refactor-separation branch from 9483abb to 6db4230 Compare August 25, 2025 13:28
@e-n-0 e-n-0 force-pushed the flavien/contrib/haproxy branch from 469c32d to 9ee5626 Compare August 25, 2025 13:29
@e-n-0 e-n-0 changed the title contrib/haproxy/stream-offload-processing: Add AAP support feat(contrib/haproxy): HAProxy AAP support Aug 25, 2025
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 25, 2025
Copy link

datadog-official bot commented Aug 25, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 39c6213 | Docs | Was this helpful? Give us feedback!

@e-n-0 e-n-0 force-pushed the flavien/contrib/haproxy branch from 6c40e5f to 5fce2b7 Compare September 8, 2025 16:08
@e-n-0 e-n-0 changed the base branch from flavien/envoy/refactor-separation to main September 17, 2025 16:06
@e-n-0 e-n-0 force-pushed the flavien/contrib/haproxy branch 4 times, most recently from f3ac150 to 2664229 Compare September 19, 2025 15:31
@e-n-0
Copy link
Member Author

e-n-0 commented Sep 22, 2025

@codex review

Copy link

Codex Review: Didn't find any major issues. You're on a roll.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@e-n-0 e-n-0 force-pushed the flavien/contrib/haproxy branch 2 times, most recently from e3f93d7 to 46b0269 Compare September 24, 2025 09:24
@e-n-0 e-n-0 force-pushed the flavien/contrib/haproxy branch from eec6d03 to 39c6213 Compare September 24, 2025 09:42
@e-n-0 e-n-0 marked this pull request as ready for review September 24, 2025 11:39
@e-n-0 e-n-0 requested review from a team as code owners September 24, 2025 11:39
@e-n-0 e-n-0 requested a review from eliottness September 24, 2025 11:39
@e-n-0 e-n-0 self-assigned this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant